chore: remove no longer needed comments (#6517)

* chore: remove no longer needed comments

- algolia/algoliasearch-helper-js#800 made the todo in numeric menu no longer needed
- template is generic

[FX-3215]

* number

Author: Haroenv

packages/algoliasearch-helper/index.d.ts

@@ -570,7 +570,7 @@ declare namespace algoliasearchHelper {
     removeNumericRefinement(
       attribute: string,
       operator?: string,
-      value?: string
+      value?: number
     ): SearchParameters;
     removeTagRefinement(tag: string): SearchParameters;
     resetPage(): SearchParameters;

packages/instantsearch-core/src/connectors/connectCurrentRefinements.ts

@@ -349,7 +349,7 @@ function clearRefinementFromState(
       return state.removeNumericRefinement(
         refinement.attribute,
         refinement.operator,
-        String(refinement.value)
+        refinement.value as number
       );
     case 'tag':
       return state.removeTagRefinement(String(refinement.value));

packages/instantsearch-core/src/connectors/connectNumericMenu.ts

@@ -34,6 +34,8 @@ export type NumericMenuConnectorParamsItem = {
   end?: number;
 };
 
+type NumericMenuValue = Omit<NumericMenuConnectorParamsItem, 'label'>;
+
 export type NumericMenuRenderStateItem = {
   /**
    *  Name of the option.
@@ -114,7 +116,6 @@ export type NumericMenuWidgetDescription = {
   };
   indexUiState: {
     numericMenu: {
-      // @TODO: this could possibly become `${number}:${number}` later
       [attribute: string]: string;
     };
   };
@@ -169,7 +170,7 @@ export const connectNumericMenu: NumericMenuConnector =
         items.map(({ start, end, label }) => ({
           label,
           value: encodeURI(JSON.stringify({ start, end })),
-          isRefined: isRefined(state, attribute, { start, end, label }),
+          isRefined: isRefined(state, attribute, { start, end }),
         }));
 
       const connectorState: ConnectorState = {};
@@ -346,9 +347,8 @@ export const connectNumericMenu: NumericMenuConnector =
 function isRefined(
   state: SearchParameters,
   attribute: string,
-  option: NumericMenuConnectorParamsItem
+  option: NumericMenuValue
 ) {
-  // @TODO: same as another spot, why is this mixing arrays & elements?
   const currentRefinements = state.getNumericRefinements(attribute);
 
   if (option.start !== undefined && option.end !== undefined) {
@@ -385,10 +385,7 @@ function getRefinedState(
   facetValue: string
 ) {
   let resolvedState = state;
-
-  const refinedOption = JSON.parse(decodeURI(facetValue));
-
-  // @TODO: why is array / element mixed here & hasRefinements; seems wrong?
+  const refinedOption: NumericMenuValue = JSON.parse(decodeURI(facetValue));
   const currentRefinements = resolvedState.getNumericRefinements(attribute);
 
   if (refinedOption.start === undefined && refinedOption.end === undefined) {

packages/instantsearch.js/src/components/Template/Template.tsx

@@ -25,7 +25,6 @@ export type TemplateProps = {
 } & PreparedTemplateProps<Templates> &
   Readonly<typeof defaultProps>;
 
-// @TODO: Template should be a generic and receive TData to pass to Templates (to avoid TTemplateData to be set as `any`)
 class Template extends Component<TemplateProps> {
   public static readonly defaultProps = defaultProps;