Skip to content

Commit 3b3df0e

Browse files
authored
Fixes regex warning when running E2E tests for external retrievers (neo4j#64)
* Fixed regex warning when running E2E tests for external retrievers * Reverted test_weaviate_neo4j_text_input_remote_embedder * Added missing regex fix * Replaced HuggingFaceEmbeddings import * Updated CHANGELOG
1 parent ab54d7b commit 3b3df0e

File tree

7 files changed

+34
-12
lines changed

7 files changed

+34
-12
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313

1414
- Removed Pinecone and Weaviate retrievers from **init**.py to prevent ImportError when optional dependencies are not installed.
1515
- Moved few-shot examples in `Text2CypherRetriever` to the constructor for better initialization and usage. Updated unit tests and example script accordingly.
16+
- Fixed regex warnings in E2E tests for Weaviate and Pinecone retrievers.
17+
- Corrected HuggingFaceEmbeddings import in E2E tests.
18+
1619

1720
## 0.2.0a5
1821

examples/pinecone/text_search.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from langchain_community.embeddings import HuggingFaceEmbeddings
1+
from langchain_huggingface.embeddings import HuggingFaceEmbeddings
22
from neo4j import GraphDatabase
33
from neo4j_genai.retrievers.external.pinecone import PineconeNeo4jRetriever
44
from pinecone import Pinecone

examples/weaviate/text_search_local_embedder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from langchain_community.embeddings import HuggingFaceEmbeddings
1+
from langchain_huggingface.embeddings import HuggingFaceEmbeddings
22
from neo4j import GraphDatabase
33
from neo4j_genai.retrievers.external.weaviate import WeaviateNeo4jRetriever
44
from weaviate.connect.helpers import connect_to_local

poetry.lock

Lines changed: 20 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ pinecone-client = "^4.1.0"
4949
langchain-community = "^0.2.0"
5050
requests = "^2.32.0"
5151
sphinx = { version = "^7.2.6", python = "^3.9" }
52+
langchain-huggingface = "^0.0.3"
5253

5354
[tool.poetry.extras]
5455
external_clients = ["weaviate-client", "pinecone-client"]

tests/e2e/pinecone_e2e/test_pinecone_e2e.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
from unittest.mock import MagicMock
1919

2020
import pytest
21-
from langchain_community.embeddings import HuggingFaceEmbeddings
22-
from neo4j_genai.retrievers.external.pinecone import PineconeNeo4jRetriever
21+
from langchain_huggingface.embeddings import HuggingFaceEmbeddings
2322
from neo4j_genai.embedder import Embedder
23+
from neo4j_genai.retrievers.external.pinecone import PineconeNeo4jRetriever
2424
from neo4j_genai.types import RetrieverResult, RetrieverResultItem
2525
from pinecone import Pinecone
2626

@@ -77,7 +77,7 @@ def test_pinecone_neo4j_vector_input(driver: MagicMock, client: MagicMock) -> No
7777
assert isinstance(result, RetrieverResultItem)
7878
pattern = (
7979
r"<Record node=<Node element_id='.+' "
80-
"labels=frozenset\({'Question'}\) properties={'question': 'In 1953 Watson \& "
80+
r"labels=frozenset\({'Question'}\) properties={'question': 'In 1953 Watson \& "
8181
"Crick built a model of the molecular structure of this, the gene-carrying "
8282
"substance', 'id': 'question_c458c6f64d8d47429636bc5a94c97f51'}> "
8383
r"score=0.232427984>"
@@ -123,7 +123,7 @@ def test_pinecone_neo4j_text_input(
123123
assert isinstance(result, RetrieverResultItem)
124124
pattern = (
125125
r"<Record node=<Node element_id='.+' "
126-
"labels=frozenset\({'Question'}\) properties={'question': 'In 1953 Watson \& "
126+
r"labels=frozenset\({'Question'}\) properties={'question': 'In 1953 Watson \& "
127127
"Crick built a model of the molecular structure of this, the gene-carrying "
128128
"substance', 'id': 'question_c458c6f64d8d47429636bc5a94c97f51'}> "
129129
r"score=0.232427984>"

tests/e2e/weaviate_e2e/test_weaviate_e2e.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from typing import Any, Generator
1818

1919
import pytest
20-
from langchain_community.embeddings import HuggingFaceEmbeddings
20+
from langchain_huggingface.embeddings import HuggingFaceEmbeddings
2121
from neo4j import Driver
2222
from neo4j_genai.embedder import Embedder
2323
from neo4j_genai.retrievers.external.weaviate import WeaviateNeo4jRetriever
@@ -67,7 +67,7 @@ def test_weaviate_neo4j_vector_input(driver: Driver, weaviate_client: Client) ->
6767
assert isinstance(results.items[0], RetrieverResultItem)
6868
pattern = (
6969
r"<Record node=<Node element_id='.+' "
70-
"labels=frozenset\({'Question'}\) properties={'question': 'In 1953 Watson \& "
70+
r"labels=frozenset\({'Question'}\) properties={'question': 'In 1953 Watson \& "
7171
"Crick built a model of the molecular structure of this, the gene-carrying "
7272
"substance', 'id': 'question_c458c6f64d8d47429636bc5a94c97f51'}> "
7373
r"score=0.6[0-9]+>"
@@ -98,7 +98,7 @@ def test_weaviate_neo4j_text_input_local_embedder(
9898
assert isinstance(results.items[0], RetrieverResultItem)
9999
pattern = (
100100
r"<Record node=<Node element_id='.+' "
101-
"labels=frozenset\({'Question'}\) properties={'question': 'In 1953 Watson \& "
101+
r"labels=frozenset\({'Question'}\) properties={'question': 'In 1953 Watson \& "
102102
"Crick built a model of the molecular structure of this, the gene-carrying "
103103
"substance', 'id': 'question_c458c6f64d8d47429636bc5a94c97f51'}> "
104104
r"score=0.6[0-9]+>"
@@ -126,7 +126,7 @@ def test_weaviate_neo4j_text_input_remote_embedder(
126126
assert isinstance(results.items[0], RetrieverResultItem)
127127
pattern = (
128128
r"<Record node=<Node element_id='.+' "
129-
"labels=frozenset\({'Question'}\) properties={'question': 'In 1953 Watson \& "
129+
r"labels=frozenset\({'Question'}\) properties={'question': 'In 1953 Watson \& "
130130
"Crick built a model of the molecular structure of this, the gene-carrying "
131131
"substance', 'id': 'question_c458c6f64d8d47429636bc5a94c97f51'}> "
132132
r"score=0.5[0-9]+>"

0 commit comments

Comments
 (0)