lint

Author: alexjustesen

app/Http/Middleware/AcceptJsonMiddleware.php

@@ -12,9 +12,7 @@ class AcceptJsonMiddleware
     /**
      * Handle an incoming request.
      *
-     * @param  \Illuminate\Http\Request  $request
      * @param  \Closure(\Illuminate\Http\Request): (\Symfony\Component\HttpFoundation\Response)  $next
-     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function handle(Request $request, Closure $next): SymfonyResponse
     {
@@ -30,11 +28,11 @@ public function handle(Request $request, Closure $next): SymfonyResponse
         $response = $next($request);
 
         // Force JSON content type if not already set
-        if (! $response->headers->has('Content-Type') || 
+        if (! $response->headers->has('Content-Type') ||
             ! str_contains($response->headers->get('Content-Type'), 'application/json')) {
             $response->headers->set('Content-Type', 'application/json');
         }
 
         return $response;
     }
-}
+}

app/OpenApi/Schemas/NotAcceptableErrorSchema.php

@@ -21,6 +21,4 @@
         ),
     ]
 )]
-class NotAcceptableErrorSchema
-{
-}
+class NotAcceptableErrorSchema {}

tests/Unit/AcceptJsonMiddlewareTest.php

@@ -2,7 +2,7 @@
 
 test('AcceptJsonMiddleware accepts requests without Accept header (Laravel default)', function () {
     // Laravel's acceptsJson() returns true when no Accept header is present
-    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware();
+    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware;
 
     $request = \Illuminate\Http\Request::create('/api/test', 'GET');
 
@@ -17,10 +17,10 @@
 });
 
 test('AcceptJsonMiddleware accepts requests with Accept: application/json header', function () {
-    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware();
+    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware;
 
     $request = \Illuminate\Http\Request::create('/api/test', 'GET', [], [], [], [
-        'HTTP_ACCEPT' => 'application/json'
+        'HTTP_ACCEPT' => 'application/json',
     ]);
 
     $response = $middleware->handle($request, function () {
@@ -35,10 +35,10 @@
 
 test('AcceptJsonMiddleware rejects requests with Accept: */json header', function () {
     // Laravel's acceptsJson() returns false for */json
-    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware();
+    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware;
 
     $request = \Illuminate\Http\Request::create('/api/test', 'GET', [], [], [], [
-        'HTTP_ACCEPT' => '*/json'
+        'HTTP_ACCEPT' => '*/json',
     ]);
 
     $response = $middleware->handle($request, function () {
@@ -53,10 +53,10 @@
 });
 
 test('AcceptJsonMiddleware accepts requests with Accept: application/* header', function () {
-    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware();
+    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware;
 
     $request = \Illuminate\Http\Request::create('/api/test', 'GET', [], [], [], [
-        'HTTP_ACCEPT' => 'application/*'
+        'HTTP_ACCEPT' => 'application/*',
     ]);
 
     $response = $middleware->handle($request, function () {
@@ -67,10 +67,10 @@
 });
 
 test('AcceptJsonMiddleware accepts requests with multiple Accept headers including application/json', function () {
-    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware();
+    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware;
 
     $request = \Illuminate\Http\Request::create('/api/test', 'GET', [], [], [], [
-        'HTTP_ACCEPT' => 'text/html,application/json,application/xml;q=0.9,*/*;q=0.8'
+        'HTTP_ACCEPT' => 'text/html,application/json,application/xml;q=0.9,*/*;q=0.8',
     ]);
 
     $response = $middleware->handle($request, function () {
@@ -81,10 +81,10 @@
 });
 
 test('AcceptJsonMiddleware rejects requests with only non-JSON Accept headers', function () {
-    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware();
+    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware;
 
     $request = \Illuminate\Http\Request::create('/api/test', 'GET', [], [], [], [
-        'HTTP_ACCEPT' => 'text/html,application/xml'
+        'HTTP_ACCEPT' => 'text/html,application/xml',
     ]);
 
     $response = $middleware->handle($request, function () {
@@ -99,10 +99,10 @@
 });
 
 test('AcceptJsonMiddleware sets Content-Type header to application/json when not already set', function () {
-    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware();
+    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware;
 
     $request = \Illuminate\Http\Request::create('/api/test', 'GET', [], [], [], [
-        'HTTP_ACCEPT' => 'application/json'
+        'HTTP_ACCEPT' => 'application/json',
     ]);
 
     $response = $middleware->handle($request, function () {
@@ -113,10 +113,10 @@
 });
 
 test('AcceptJsonMiddleware preserves existing application/json Content-Type header', function () {
-    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware();
+    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware;
 
     $request = \Illuminate\Http\Request::create('/api/test', 'GET', [], [], [], [
-        'HTTP_ACCEPT' => 'application/json'
+        'HTTP_ACCEPT' => 'application/json',
     ]);
 
     $response = $middleware->handle($request, function () {
@@ -127,10 +127,10 @@
 });
 
 test('AcceptJsonMiddleware rejects requests that only accept HTML', function () {
-    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware();
+    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware;
 
     $request = \Illuminate\Http\Request::create('/api/test', 'GET', [], [], [], [
-        'HTTP_ACCEPT' => 'text/html'
+        'HTTP_ACCEPT' => 'text/html',
     ]);
 
     $response = $middleware->handle($request, function () {
@@ -146,15 +146,15 @@
 
 test('AcceptJsonMiddleware accepts requests with */* Accept header', function () {
     // Laravel's acceptsJson() returns true for */*
-    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware();
+    $middleware = new \App\Http\Middleware\AcceptJsonMiddleware;
 
     $request = \Illuminate\Http\Request::create('/api/test', 'GET', [], [], [], [
-        'HTTP_ACCEPT' => '*/*'
+        'HTTP_ACCEPT' => '*/*',
     ]);
 
     $response = $middleware->handle($request, function () {
         return response()->json(['success' => true]);
     });
 
     expect($response->getStatusCode())->toBe(200);
-});
+});