Skip to content

Commit 0ef9a3d

Browse files
committed
Print newline on feedback if not already present
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
1 parent 00516ba commit 0ef9a3d

File tree

1 file changed

+6
-19
lines changed

1 file changed

+6
-19
lines changed

handler/comment_handler.go

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -72,37 +72,24 @@ func HandleComment(req types.IssueCommentOuter, config config.Config, derekConfi
7272
switch command.Type {
7373

7474
case addLabelConstant, removeLabelConstant:
75-
7675
feedback, err = manageLabel(req, command.Type, command.Value, config)
77-
break
7876

7977
case assignConstant, unassignConstant:
80-
8178
feedback, err = manageAssignment(req, command.Type, command.Value, config)
82-
break
8379

8480
case closeConstant, reopenConstant:
85-
8681
feedback, err = manageState(req, command.Type, config)
87-
break
8882

8983
case setTitleConstant:
90-
9184
feedback, err = manageTitle(req, command.Type, command.Value, config)
92-
break
9385

9486
case lockConstant, unlockConstant:
95-
9687
feedback, err = manageLocking(req, command.Type, config)
97-
break
9888

9989
case setMilestoneConstant, removeMilestoneConstant:
100-
10190
feedback, err = updateMilestone(req, command.Type, command.Value, config)
102-
break
10391

10492
case assignReviewerConstant, unassignReviewerConstant:
105-
10693
pr := types.PullRequest{
10794
Number: req.Issue.Number,
10895
}
@@ -113,22 +100,22 @@ func HandleComment(req types.IssueCommentOuter, config config.Config, derekConfi
113100
InstallationRequest: req.InstallationRequest,
114101
}
115102
feedback, err = editReviewers(prReq, command.Type, command.Value, config)
116-
break
117103

118104
case messageConstant:
119-
120105
feedback, err = createMessage(req, command.Type, command.Value, config, derekConfig)
121-
break
122106

123107
default:
124-
feedback = "No command found in comment"
108+
feedback = "No command found in comment\n"
125109

126110
if strings.HasPrefix(req.Comment.Body, "Derek ") || strings.HasPrefix(req.Comment.Body, "/") {
127-
feedback = fmt.Sprintf("Unable to work with command: %q", req.Comment.Body)
111+
feedback = fmt.Sprintf("Unable to work with command: %q\n", req.Comment.Body)
128112
}
129113

130114
err = nil
131-
break
115+
}
116+
117+
if !strings.HasSuffix(feedback, "\n") {
118+
feedback += "\n"
132119
}
133120

134121
fmt.Print(feedback)

0 commit comments

Comments
 (0)