W60G Support possible?

[NoobieElf]

Hi there, thankyou for making this excellent tool!

Is it possible to get W60G support enabled? I couldn't find any metrics enabled for it, but sorry if I've missed something simple.

[hslabbert]

I'll +1 in here. It seems like it probably should be feasible, though would need datasource and collector definitions. I've got a new Wireless Wire setup and would like to pull this info in as well. Basically, it seems like we'd need to pull and then structure the info under /interface/w60g/monitor, e.g.:

[admin@ww1a] > /interface/w60g/monitor wlan60-1 once
             connected: yes                              
             frequency: 58320                            
        remote-address: 04:F4:1C:6F:76:95                
                tx-mcs: 8                                
           tx-phy-rate: 2.3Gbps                          
                signal: 95                               
                  rssi: -53                              
             tx-sector: 44                               
        tx-sector-info: left 3.8 degrees, up 11.4 degrees
              distance: 57.12m                           
  baseband-temperature: 35.039                           
        rf-temperature: 38.3                             
  tx-packet-error-rate: 0% 

[hslabbert]

I stand corrected. Well, kind of. It looks like the existing InterfaceMonitorMetricsDataSource may be the way to go there, though probably it's more sensible to create a different collector rather than using the existing MonitorCollector, though I'm a bit TBD on that.

The other bit may be the w60g vs. w60g-station interface pieces. The info we want is in w60g, though there may a bit of weirdness here with w60g vs. w60g-station in terms of the running flags. Best I can tell, at least in my Wireless Wire / wAP 60G kit:
The primary will have a w60g/station interface, with running status on that station interface but not on its w60g interface. The secondary will have its running status on its w60g interface but will not have a w60g/station interface. That may require some tweaks or conditionals or such in InterfaceMonitorMetricsDataSource as there is a filter for running interfaces in there. We could force it with running_only = False on that metrics call, but that's definitely janky.

I'm poking away at this for curiosity's sake, and will see if I can find some time to take a stab at it.

[hslabbert]

k, I have a basic PoC of this using InterfaceMonitorMetricsDataSource with a separate w60g_collector and keying this into a w60g config bool, that seems to work.

I've confirmed the basic prom metrics seem to be functional, but the following are outstanding:

• interface names: w60g interfaces with comments show names properly, but without don't. Need to check what's up there; possibly string parsing issue with hyphen names (wlan60-1)?
• w60g vs. w60g/station: Have not done any logic/checking/validation on that

PoC code at https://github.com/hslabbert/mktxp/tree/w60g

Example prom metrics (note the explicit w60gcomment iface name there):

# HELP mktxp_w60g_baseband_temperature Baseband unit temperature
# TYPE mktxp_w60g_baseband_temperature gauge
mktxp_w60g_baseband_temperature{name="w60gcomment",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b"} 28.73
# HELP mktxp_w60g_connected Connected status
# TYPE mktxp_w60g_connected gauge
mktxp_w60g_connected{name="w60gcomment",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b"} 0.0
# HELP mktxp_w60g_distance Distance to W60G peer
# TYPE mktxp_w60g_distance gauge
mktxp_w60g_distance{name="w60gcomment",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b"} 57.11
# HELP mktxp_w60g_frequency Frequency of W60G link
# TYPE mktxp_w60g_frequency gauge
mktxp_w60g_frequency{name="w60gcomment",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b"} 58320.0
# HELP mktxp_w60g_remote_address_info MAC address of W60G peer
# TYPE mktxp_w60g_remote_address_info gauge
mktxp_w60g_remote_address_info{name="w60gcomment",remote_address="04:F4:1C:6F:76:83",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b"} 1.0
# HELP mktxp_w60g_rf_temperature RF module temperature
# TYPE mktxp_w60g_rf_temperature gauge
mktxp_w60g_rf_temperature{name="w60gcomment",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b"} 33.2
# HELP mktxp_w60g_rssi Link Received Signal Strength Indicator (RSSI)
# TYPE mktxp_w60g_rssi gauge
mktxp_w60g_rssi{name="w60gcomment",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b"} -55.0
# HELP mktxp_w60g_signal Link Signal Strength
# TYPE mktxp_w60g_signal gauge
mktxp_w60g_signal{name="w60gcomment",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b"} 95.0
# HELP mktxp_w60g_tx_mcs Transmission MCS
# TYPE mktxp_w60g_tx_mcs gauge
mktxp_w60g_tx_mcs{name="w60gcomment",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b"} 8.0
# HELP mktxp_w60g_tx_packet_error_rate Transmission error rate (percentage)
# TYPE mktxp_w60g_tx_packet_error_rate gauge
mktxp_w60g_tx_packet_error_rate{name="w60gcomment",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b"} 0.0
# HELP mktxp_w60g_tx_phy_rate Transmission PHY rate
# TYPE mktxp_w60g_tx_phy_rate gauge
mktxp_w60g_tx_phy_rate{name="w60gcomment",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b"} 2.31e+012
# HELP mktxp_w60g_tx_sector_info Transmission sector info (alignment)
# TYPE mktxp_w60g_tx_sector_info gauge
mktxp_w60g_tx_sector_info{name="w60gcomment",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b",tx_sector_info="center"} 1.0
# HELP mktxp_w60g_tx_sector Transmission sector number
# TYPE mktxp_w60g_tx_sector gauge
mktxp_w60g_tx_sector{name="w60gcomment",routerboard_address="ww1b.int.example.com",routerboard_name="ww1b"} 27.0

[hslabbert]

Oh, also, it looks like I should drop the use of the BaseOutputProcessor.parse_interface_rate() function on the tx_phy_rate, as I'm pretty sure I'm not running the link at 2.31 Tbps. It seems that while this shows up in human-friendly units (2.31 Gbps) in the cli print output, it shows up in actual bps in the API.

[hslabbert]

Example dash of these metrics from #273

[akpw]

covered by above PR

[hslabbert]

@akpw one bit I forgot:

I do have some panels for the Grafana dash defined like in the screenshot above. Is there somewhere I should e.g. share over the relevant json snippets of the exported dash?