Skip to content

Add audio recording with sync option to 2d viewer #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ReneRebsdorf opened this issue Oct 19, 2024 · 6 comments
Open

Add audio recording with sync option to 2d viewer #952

ReneRebsdorf opened this issue Oct 19, 2024 · 6 comments

Comments

@ReneRebsdorf
Copy link

What problem is this solving

Being able to listen to communications from a discord or teamspeak server would provide great insight and context to the analyzed video

Proposed solution

  • Add option for matches to allow referencing an mp3 (or other audio format)
  • Provide option to sync the audio to the 2d video manually (recordings are unlikely to start at the same time as match recording)
  • Based on known factors for how long it takes from a round to start after "round end", it should be possible to align each round with the correct time for the audio recording

Describe alternatives you've considered

N/A

@ReneRebsdorf
Copy link
Author

@akiver what are your thoughts on this? Is this something that would potentially be merged into cs-demo-manager or is it out of scope?

@akiver
Copy link
Owner

akiver commented Apr 8, 2025

while it could work, i'm a bit concerned that manually syncing the audio would be painful for users.
also, I'm not sure about the accuracy when changing rounds, have to give a try.

@ReneRebsdorf
Copy link
Author

I see, solutions such as Skybox Edge

It would be great to have an open source alternative, and based on my research your cs-demo-manager is what comes closest.
I was in touch with Scope.gg and Leetify, but both have accuracy issues with their videos (e.g. during video playback a second is not accurate to a real life second), which of course is a big blocker for adding external audio. My tests for your solution proved to be accurate.

@ReneRebsdorf
Copy link
Author

@akiver something I didn't mention previously is that yeah: the synching is annoying to do, but it is worth it for those of us who use this as part of team analysis, and once you get into a habit it isn't too bad. Just providing a number in 10th of a second to delay the video to delay (allow negatives and positives), then we would just take note of how delayed my audio is by saying "Go" at the start of the 1st round (after freezetime). Other more fancy methods probably exists too.

Wrt. to changing rounds, it also has to account for pauses such as timeouts, and the 2d replayer would need to be able to auto-start each round.

@akiver
Copy link
Owner

akiver commented May 11, 2025

Just a heads-up, I will tackle this feature request before starting to work on this one.
It will help me since I will be able to generate the audio file for a full match length file.
I have a draft that works for CSGO demos, and have to make it work for CS2 demos.

@ReneRebsdorf
Copy link
Author

Just a heads-up, I will tackle this feature request before starting to work on this one.
It will help me since I will be able to generate the audio file for a full match length file.
I have a draft that works for CSGO demos, and have to make it work for CS2 demos.

That's awesome! Thank you for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants