Not possible to use Visual Swatch attributes

[simonrl]

Environment and configuration

1. Magento 2 Open Source 2.4.6-p3
2. Akeneo CE 7.0.13
3. Connector 104.3.7

Steps to reproduce

1. have "Simple Select" attribute in Akeneo
2. configure it as "Visual Swatch" in the Akeneo-Connector-Configuration
3. import everything
4. add colors / images to swatch options in Magento
5. import "option"

Expected result

1. The swatch colors/images should stay intact

Actual result

1. The colors/images are removed

Additional info

We also tried to remove the attribute again from the Akeneo-Connector-Configuration's attribute type mapping, which results in: "option"-import works fine, but "attribute" import changes the attribute type in Magento from "Visual Swatch" to "Drop Down". After this is changed manually, the swatch colors/images are still there.

The comment for the Job/Option::insertSwatchOption() reads

Insert Swatch options Values for swatch attributes (visual swatch have no data on V1)

...so how are we supposed to handle Visual Swatches, if no configuration seems to work?

[akosglue]

I could reproduce this issue with
CE 7.0.66
magento 2.4.7
connector 104.3.7
Annoying because you select all the colors for each swatch and in 1 second your work is gone.

edit: after a closer look, this line and the next should be properly changed:

magento2-connector-community/Job/Option.php

Line 560 in 1815946

'type' => ($swatchesAttributes[$swatchesAttributeData['attribute']] === Swatch::SWATCH_TYPE_TEXTUAL_ATTRIBUTE_FRONTEND_INPUT) ? Swatch::SWATCH_TYPE_TEXTUAL : Swatch::SWATCH_TYPE_EMPTY,

so that other types are checked as well like SWATCH_TYPE_VISUAL_ATTRIBUTE_FRONTEND_INPUT
and the correspondent type is inserted like SWATCH_TYPE_VISUAL_COLOR or SWATCH_TYPE_VISUAL_IMAGE, etc.

[akosglue]

@simonrl you may try the aforementioned PR that fixes the color/images issue.
Tested with m2 2.4.7, php 8.3, akeneo 7.0.66 with sample data, connector 104.3.7

[INPVLSA]

Hello there. I see this issue has been open for a while.

I'm still doubting the relation to the current issue, but

Recently, I have upgraded Akeneo 5.x to Akeneo 7.x on my project alongside Magento and Akeneo integration module upgrade.
And found I've been missing attribute visual/text swatch specifics after the first import.

After debugging the issue, I found that changes from

ca8de2d

prevents you from having any swatch attributes, until you use Webkul extension for Akeneo (or patched module, ofc). Otherwise all the attribute_data field with types != Webkul custom will be set to NULL.

In attribute import helper we can find this pim_catalog_swatch_visual and pim_catalog_swatch_text attribute type mentions

https://github.com/akeneo/magento2-connector-community/blob/master/Helper/Import/Attribute.php#L230-L245

And even "ONLY-IF"-like mappings

https://github.com/akeneo/magento2-connector-community/blob/master/Job/Attribute.php#L576-L581

While none of these attributes is a part of native Akeneo, both introduced in this 3rd party Akeneo extension by Webkul.

All the attributes with type different to these 2 Webkul additional_data with be set to NULL, and it will cause simple select appearance.

I understand the things about vendor partnership (as an explanation why 3rd party extension provider types here), etc.

But the problem is it removed part of important functionality provided by this integration module worked properly before (until you patch the module).

Swatch types mapping configuration added allows you to only map Akeneo type <-> Magento type, not attribute <-> Visual Swatch type.

Please correct me if I'm wrong or missing something. Otherwise, I suggest preserving the attribute additional_data field if it's not null in DB and attribute type does not match Webkul-added custom types.

master...INPVLSA:magento2-connector-community:master