September 19-25, 2021 in Darker: Addressing performance and compatibility challenges #659
akaihola
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
This week, we focused on addressing several performance and compatibility issues. We discussed potential solutions for the pre-commit integration problem (#180), where users encountered errors when running Darker as a pre-commit hook on the git HEAD commit. One proposal suggests allowing Darker to modify files when called by pre-commit under specific conditions, using a special
--revision=:PRE-COMMIT:
flag and$PRE_COMMIT_TO_REF=HEAD
environment variable.We also delved into performance optimization for large files and bisection scenarios (#205). Several areas for improvement were identified, including caching intermediate comparison results and optimizing the bisection process. Additionally, we clarified the behavior of Darker on all-whitespace files (#166), noting that it currently differs from Black. We're considering aligning Darker's behavior with a potential change in Black's public API, which would format all-whitespace files as a single newline.
A compatibility issue with older versions of isort was addressed (#157), highlighting the importance of maintaining compatibility with various versions of our dependencies. We also discussed the typing_extensions dependency issue (#202), which appears to be related to Pipenv's handling of dependency resolution. For now, users experiencing this issue can use the
--skip-lock
option as a workaround.Beta Was this translation helpful? Give feedback.
All reactions