Skip to content

Commit e52c19f

Browse files
committed
fixed bug with precomputed feature input
1 parent 308c365 commit e52c19f

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

examples/nn_pes_butene.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,14 @@
9898
}
9999

100100
nn.create({
101-
# 'e': hyper_energy,
102-
'eg': hyper_grads,
101+
'e': hyper_energy,
102+
# 'eg': hyper_grads,
103103
# 'nac2': hyper_nac2
104104
})
105105

106106
y = {
107-
# 'e': eng,
108-
'eg': [eng, grads],
107+
'e': eng,
108+
# 'eg': [eng, grads],
109109
# 'nac2' : nac,
110110
}
111111

pyNNsMD/models/mlp_e.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,8 @@ def call(self, data, training=False, **kwargs):
152152
temp_g = tape2.batch_jacobian(temp_e, x)
153153
y_pred = [temp_e, temp_g]
154154
elif self.precomputed_features:
155-
feat_flat_std = self.std_layer(x)
155+
x1 = x[0]
156+
feat_flat_std = self.std_layer(x1)
156157
temp_hidden = self.mlp_layer(feat_flat_std, training=training)
157158
temp_e = self.energy_layer(temp_hidden)
158159
y_pred = temp_e

pyNNsMD/nn_pes_src/training/training_mlp_e.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,14 +166,14 @@ def train_model_energy(i=0, outdir=None, mode='training'):
166166
x_rescale, y1 = scaler.transform(x, y)
167167

168168
# Model + Model precompute layer +feat
169-
feat_x, _ = out_model.precompute_feature_in_chunks(x_rescale, batch_size=batch_size)
169+
feat_x, feat_grad = out_model.precompute_feature_in_chunks(x_rescale, batch_size=batch_size)
170170
feat_x_mean, feat_x_std = out_model.set_const_normalization_from_features(feat_x,normalization_mode=normalize_feat)
171171

172172

173173
# Train Test split
174-
xtrain = feat_x[i_train]
174+
xtrain = [feat_x[i_train], feat_grad[i_train]]
175175
ytrain = y1[i_train]
176-
xval = feat_x[i_val]
176+
xval = [feat_x[i_val], feat_grad[i_val]]
177177
yval = y1[i_val]
178178

179179
# Compile model

0 commit comments

Comments
 (0)