-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Description
Following discussion with @bgola today, ideas for uni/simplification:
Both SyncText and CodingDojo contain an OSCRouterClient
instance which has username, groupname, serveraddress
, so the corresponding instvars in SyncText and CodingDojo are duplications.
These could be unified as follows:
- SyncText.userID just calls OSCRouterClient.userName etc.
- Both SyncText and CodingDojo get two creation methods:
One is with an existing oscRouter, like SyncText is, minus the userID arg:
~oscar = OSCRouterClient(...);
SyncText.using(~textID, ~oscar);
CodingDojo.using(~dojoID, ~oscar);
two is with all args for the OSCRouterClient (as CodingDojo does already):
SyncText(\textID, ~userName, ~groupName, ~serverAddr, ~userpassword, etc etc ));
CodingDojo(~userName, ~dojoName, ~serverAddr, ...);
Metadata
Metadata
Assignees
Labels
No labels