Skip to content

Unify SyncText, CodingDojo creation and instVar use #8

@adcxyz

Description

@adcxyz

Following discussion with @bgola today, ideas for uni/simplification:

Both SyncText and CodingDojo contain an OSCRouterClient instance which has username, groupname, serveraddress, so the corresponding instvars in SyncText and CodingDojo are duplications.

These could be unified as follows:

  • SyncText.userID just calls OSCRouterClient.userName etc.
  • Both SyncText and CodingDojo get two creation methods:
    One is with an existing oscRouter, like SyncText is, minus the userID arg:
~oscar = OSCRouterClient(...);
SyncText.using(~textID, ~oscar); 
CodingDojo.using(~dojoID, ~oscar); 

two is with all args for the OSCRouterClient (as CodingDojo does already):

SyncText(\textID, ~userName, ~groupName, ~serverAddr, ~userpassword, etc etc )); 
CodingDojo(~userName, ~dojoName, ~serverAddr, ...);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions