From 5f0d419c7e04b9e0bf401ce216f382cbf611180e Mon Sep 17 00:00:00 2001
From: Artem Simeshin <a.simeshin@gmail.com>
Date: Fri, 20 Jun 2025 15:48:51 +0300
Subject: [PATCH 1/2] =?UTF-8?q?=D0=94=D0=BE=D0=B1=D0=B0=D0=B2=D0=BB=D0=B5?=
 =?UTF-8?q?=D0=BD=20=D0=BF=D0=BB=D0=B0=D0=B3=D0=B8=D0=BD=20maven-pmd-plugi?=
 =?UTF-8?q?n=20=D0=B4=D0=BB=D1=8F=20=D0=BF=D1=80=D0=BE=D0=B2=D0=B5=D1=80?=
 =?UTF-8?q?=D0=BA=D0=B8=20=D0=BA=D0=B0=D1=87=D0=B5=D1=81=D1=82=D0=B2=D0=B0?=
 =?UTF-8?q?=20=D0=BA=D0=BE=D0=B4=D0=B0?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Closes #6

Signed-off-by: Artem Simeshin <a.simeshin@gmail.com>
---
 configs/pmd-ruleset.xml | 90 +++++++++++++++++++++++++++++++++++++++++
 pom.xml                 | 21 ++++++++++
 2 files changed, 111 insertions(+)
 create mode 100644 configs/pmd-ruleset.xml

diff --git a/configs/pmd-ruleset.xml b/configs/pmd-ruleset.xml
new file mode 100644
index 0000000..108dd44
--- /dev/null
+++ b/configs/pmd-ruleset.xml
@@ -0,0 +1,90 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ruleset name="Base ruleset" xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
+
+    <description>General Java quality rules</description>
+
+    <!-- https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html -->
+    <rule ref="category/java/bestpractices.xml">
+        <exclude name="AccessorMethodGeneration"/>
+        <exclude name="LooseCoupling"/>
+        <exclude name="GuardLogStatement"/>
+    </rule>
+
+    <!-- https://pmd.github.io/pmd/pmd_rules_java_codestyle.html -->
+    <rule ref="category/java/codestyle.xml">
+        <exclude name="AtLeastOneConstructor"/>
+        <exclude name="CommentDefaultAccessModifier"/>
+        <exclude name="LocalHomeNamingConvention"/>
+        <exclude name="LocalInterfaceSessionNamingConvention"/>
+        <exclude name="MDBAndSessionBeanNamingConvention"/>
+        <exclude name="OnlyOneReturn"/>
+        <exclude name="RemoteInterfaceNamingConvention"/>
+        <exclude name="RemoteSessionInterfaceNamingConvention"/>
+        <exclude name="LongVariable"/>
+        <exclude name="ShortVariable"/>
+        <exclude name="UnnecessaryAnnotationValueElement"/>
+        <exclude name="UseExplicitTypes"/>
+    </rule>
+
+    <!-- https://pmd.github.io/pmd/pmd_rules_java_codestyle.html#linguisticnaming -->
+    <rule ref="category/java/codestyle.xml/LinguisticNaming">
+        <properties>
+            <property name="checkSetters" value="false"/>
+        </properties>
+    </rule>
+
+    <!-- https://pmd.github.io/pmd/pmd_rules_java_design.html -->
+    <rule ref="category/java/design.xml">
+        <exclude name="LoosePackageCoupling"/>
+        <exclude name="LawOfDemeter"/>
+        <exclude name="AvoidCatchingGenericException"/>
+        <exclude name="DataClass"/>
+    </rule>
+
+    <!-- https://pmd.github.io/pmd/pmd_rules_java_documentation.html -->
+    <rule ref="category/java/documentation.xml">
+        <exclude name="CommentSize"/>
+    </rule>
+
+    <!-- https://pmd.github.io/pmd/pmd_rules_java_errorprone.html -->
+    <rule ref="category/java/errorprone.xml">
+        <exclude name="AvoidAccessibilityAlteration"/>
+        <exclude name="AvoidFieldNameMatchingMethodName"/>
+        <exclude name="JUnitSpelling"/>
+        <exclude name="JUnitStaticSuite"/>
+        <exclude name="MissingSerialVersionUID"/>
+        <exclude name="NullAssignment"/> <!-- disabled due to false positive for initialization with ternary operator -->
+        <exclude name="StaticEJBFieldShouldBeFinal"/>
+        <exclude name="UseProperClassLoader"/>
+    </rule>
+
+    <!-- https://pmd.github.io/pmd/pmd_rules_java_errorprone.html#avoidduplicateliterals -->
+    <rule ref="category/java/errorprone.xml/AvoidDuplicateLiterals">
+        <properties>
+            <property name="skipAnnotations" value="true"/>
+        </properties>
+    </rule>
+
+    <!-- https://pmd.github.io/pmd/pmd_rules_java_errorprone.html#closeresource -->
+    <rule ref="category/java/errorprone.xml/CloseResource">
+        <properties>
+            <property name="types" value="java.sql.Connection,java.sql.Statement,java.sql.ResultSet"/>
+        </properties>
+    </rule>
+
+    <!-- https://pmd.github.io/pmd/pmd_rules_java_multithreading.html -->
+    <rule ref="category/java/multithreading.xml">
+        <exclude name="DoNotUseThreads"/>
+        <exclude name="UseConcurrentHashMap"/>
+    </rule>
+
+    <!-- https://pmd.github.io/pmd/pmd_rules_java_performance.html -->
+    <rule ref="category/java/performance.xml">
+        <exclude name="AvoidInstantiatingObjectsInLoops"/>
+    </rule>
+
+    <!-- https://pmd.github.io/pmd/pmd_rules_java_security.html -->
+    <rule ref="category/java/security.xml"/>
+</ruleset>
\ No newline at end of file
diff --git a/pom.xml b/pom.xml
index df97cc9..56b171d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -270,6 +270,27 @@
                     </execution>
                 </executions>
             </plugin>
+
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-pmd-plugin</artifactId>
+                <version>3.26.0</version>
+                <configuration>
+                    <failOnViolation>false</failOnViolation>
+                    <rulesets>
+                        <ruleset>${project.parent.basedir}/configs/pmd-ruleset.xml</ruleset>
+                    </rulesets>
+                </configuration>
+                <executions>
+                    <execution>
+                        <id>pmd</id>
+                        <phase>verify</phase>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
         </plugins>
     </build>
 

From e82989e6c1cfdf26ade66f7cea08655de84a39b4 Mon Sep 17 00:00:00 2001
From: Artem Simeshin <a.simeshin@gmail.com>
Date: Fri, 20 Jun 2025 16:02:34 +0300
Subject: [PATCH 2/2] =?UTF-8?q?=D0=A1=D0=BA=D0=BE=D1=80=D1=80=D0=B5=D0=BA?=
 =?UTF-8?q?=D1=82=D0=B8=D1=80=D0=BE=D0=B2=D0=B0=D0=BB=20github=20workflow?=
 =?UTF-8?q?=20=D0=B4=D0=BB=D1=8F=20=D0=BF=D1=80=D0=BE=D1=85=D0=BE=D0=B6?=
 =?UTF-8?q?=D0=B4=D0=B5=D0=BD=D0=B8=D1=8F=20=D0=BF=D1=80=D0=BE=D0=B2=D0=B5?=
 =?UTF-8?q?=D1=80=D0=BE=D0=BA=20=D0=BD=D0=B0=20=D1=81=D1=82=D0=B0=D0=B4?=
 =?UTF-8?q?=D0=B8=D0=B8=20verify?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Artem Simeshin <a.simeshin@gmail.com>
---
 .github/workflows/maven-build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/maven-build.yml b/.github/workflows/maven-build.yml
index b7fe4a1..dd752c4 100644
--- a/.github/workflows/maven-build.yml
+++ b/.github/workflows/maven-build.yml
@@ -21,4 +21,4 @@ jobs:
           distribution: 'temurin'
 
       - name: Build with Maven (unit tests only)
-        run: mvn clean test --no-transfer-progress
+        run: mvn clean verify --no-transfer-progress