Fix selecting a unique value from gene space

Author: Ahmed Gad

.DS_Store

@@ -349,12 +349,9 @@ def generate_gene_value_from_space(self,
                 # We must check if the selected value will respect the allow_duplicate_genes parameter.
                 # Instead of selecting a value randomly, we have to select a value that will be unique if allow_duplicate_genes=False.
                 # Only select a value from the current gene space that is, hopefully, unique.
-                print("KKKKKKKK", value_from_space)
                 value_from_space = self.select_unique_value(gene_values=value_from_space,
                                                             solution=solution,
                                                             gene_index=gene_idx)
-                print("<<<<<<<<<<", value_from_space)
-                # TODO WHY THIS VALUE IS NONE
 
             # The gene space might be [None, 1, 7].
             # It might happen that the value None is selected.

example.py

@@ -262,12 +262,17 @@ def select_unique_value(self, gene_values, solution, gene_index):
         """
 
         values_to_select_from = list(set(list(gene_values)) - set(solution))
-        print("PPPPPPPPP", values_to_select_from)
 
         if len(values_to_select_from) == 0:
-            # If there are no values, then keep the current gene value.
-            if not self.suppress_warnings: warnings.warn(f"'allow_duplicate_genes=False' but cannot find a unique value for the gene at index {gene_index} with value {solution[gene_index]}.")
-            selected_value = solution[gene_index]
+            if solution[gene_index] is None:
+                # The initial population is created as an empty array (numpy.empty()).
+                # If we are assigning values to the initial population, then the gene value is already None.
+                # If the gene value is None, then we do not have an option other than selecting a value even if it causes duplicates.
+                # If there is no value that is unique to the solution, then select any of the current values randomly from the current set of gene values.
+                selected_value = random.choice(gene_values)
+            else:
+                # If the gene is not None, then just keep its current value as long as there are no values that make it unique.
+                selected_value = solution[gene_index]
         else:
             selected_value = random.choice(values_to_select_from)
         return selected_value
@@ -307,7 +312,6 @@ def unique_genes_by_space(self,
                                                  build_initial_pop=build_initial_pop)
 
             if temp_val in solution:
-                # self.logger.info("temp_val, duplicate_index", temp_val, duplicate_index, solution)
                 num_unsolved_duplicates = num_unsolved_duplicates + 1
                 if not self.suppress_warnings: warnings.warn(f"Failed to find a unique value for gene with index {duplicate_index} whose value is {solution[duplicate_index]}. Consider adding more values in the gene space or use a wider range for initial population or random mutation.")
             else:

example2.py

@@ -1404,7 +1404,6 @@ def initialize_population(self,
                                                                                              gene_value=None,
                                                                                              solution=self.population[sol_idx],
                                                                                              sample_size=1)
-                    print('AAAAAAAAA', self.population[sol_idx, gene_idx])
 
         # 2) Change the data type and round all genes within the initial population.
         self.population = self.change_population_dtype_and_round(self.population)