Update

Author: dirkbrnd

libs/agno/agno/api/agent.py

@@ -61,7 +61,7 @@ def create_agent(agent: AgentCreate) -> None:
                 ApiRoutes.AGENT_CREATE,
                 json=agent.model_dump(exclude_none=True),
             )
-            
+
             log_debug(f"Created Agent on Platform. ID: {agent.agent_id}")
         except Exception as e:
             log_debug(f"Could not create Agent: {e}")

libs/agno/agno/models/openai/chat.py

@@ -185,7 +185,7 @@ def get_request_kwargs(
         # Add tools
         if tools is not None and len(tools) > 0:
             request_params["tools"] = tools
-            
+
             if tool_choice is not None:
                 request_params["tool_choice"] = tool_choice
 

libs/agno/agno/utils/json_schema.py

@@ -143,7 +143,7 @@ def get_json_schema_for_arg(type_hint: Any) -> Optional[Dict[str, Any]]:
     elif issubclass(type_hint, BaseModel):
         # Get the schema and inline it
         schema = type_hint.model_json_schema()
-        return inline_pydantic_schema(schema)
+        return inline_pydantic_schema(schema)  # type: ignore
     elif hasattr(type_hint, "__dataclass_fields__"):
         # Convert dataclass to JSON schema
         properties = {}
@@ -152,21 +152,23 @@ def get_json_schema_for_arg(type_hint: Any) -> Optional[Dict[str, Any]]:
         for field_name, field in type_hint.__dataclass_fields__.items():
             field_type = field.type
             field_schema = get_json_schema_for_arg(field_type)
-            
-            if "anyOf" in field_schema and any(schema["type"] == "null" for schema in field_schema["anyOf"]):
-                field_schema["type"] = next(schema["type"] for schema in field_schema["anyOf"] if schema["type"] != "null")
+
+            if (
+                field_schema
+                and "anyOf" in field_schema
+                and any(schema["type"] == "null" for schema in field_schema["anyOf"])
+            ):
+                field_schema["type"] = next(
+                    schema["type"] for schema in field_schema["anyOf"] if schema["type"] != "null"
+                )
                 field_schema.pop("anyOf")
             else:
                 required.append(field_name)
 
             if field_schema:
                 properties[field_name] = field_schema
 
-        arg_json_schema = {
-            "type": "object",
-            "properties": properties,
-            "additionalProperties": False
-        }
+        arg_json_schema = {"type": "object", "properties": properties, "additionalProperties": False}
 
         if required:
             arg_json_schema["required"] = required

libs/agno/tests/unit/utils/test_json_schema.py

@@ -12,14 +12,14 @@
 
 
 # Test models and dataclasses
-class TestPydanticModel(BaseModel):
+class MockPydanticModel(BaseModel):
     name: str
     age: int
     is_active: bool = True
 
 
 @dataclass
-class TestDataclass:
+class MockDataclass:
     name: str
     age: int
     is_active: bool = True
@@ -115,7 +115,7 @@ def test_get_json_schema_for_arg_collections():
 def test_get_json_schema_for_arg_union():
     # Test Optional type (Union with None)
     optional_schema = get_json_schema_for_arg(Optional[str])
-    assert optional_schema == {'anyOf': [{'type': 'string'}, {'type': 'null'}]}
+    assert optional_schema == {"anyOf": [{"type": "string"}, {"type": "null"}]}
 
     # Test Union type
     union_schema = get_json_schema_for_arg(Union[str, int])
@@ -146,7 +146,7 @@ def test_get_json_schema_basic():
 
 
 def test_get_json_schema_with_pydantic_model():
-    type_hints = {"user": TestPydanticModel}
+    type_hints = {"user": MockPydanticModel}
     schema = get_json_schema(type_hints)
     assert schema["type"] == "object"
     assert "properties" in schema
@@ -161,7 +161,7 @@ def test_get_json_schema_with_pydantic_model():
 
 
 def test_get_json_schema_with_dataclass():
-    type_hints = {"user": TestDataclass}
+    type_hints = {"user": MockDataclass}
     schema = get_json_schema(type_hints)
     assert schema["type"] == "object"
     assert "properties" in schema
@@ -226,7 +226,7 @@ def test_get_json_schema_with_nested_pydantic_models():
 
     # Verify optional phone field
     assert "phone" in contact_info["properties"]
-    assert contact_info["properties"]["phone"]["default"] == None
+    assert contact_info["required"] == ["email", "address"]
 
     # Verify preferences dictionary
     assert "preferences" in user_profile["properties"]