Skip to content

Commit 6d6dcd1

Browse files
committed
deps: migrate from Enzyme to RTL (#88)
* deps: migrate from Enzyme to RTL - Enzyme only has unofficial support for React 17 and no support what-so-ever for React 18, so forced to migrate - RTL is most certainly more of an integration testing library than a unit test library - can't access the instance through RTL, even though this component actually _needs_ to use refs (bc canvas) - I managed to hack around this by using refs, but I honestly wasn't even sure that this was possible - notably hooks like `useRef` don't work since they can only be used inside of a React component or another hook - but callback refs and `createRef` do work fortunately - tried to use `react-dom-instance` initially, as suggested in blog post by the author, but it only works with React 16 - in React 17 and React 18 it just returns `false` and doesn't get an instance - `querySelector` is an escape hatch that is not recommended, enough so that I read through the docs multiple times before finding it was even possible - was using `document.querySelector` directly before finding this - somewhat replaces Enzyme's `exists` - `rerender` is also a bit of an escape hatch - notably, you can't set props directly on a `ref`, `.props` is a read-only property, so had to find some alternative to be able to run the tests - replaces Enzyme's `setProps` - had to change `clearOnResize` to an optional type as it was required without this - despite that it's in `defaultProps`; the interface itself can't infer this, so probably makes sense to make it optional here as well * fix lint issues
1 parent 17ba39d commit 6d6dcd1

File tree

5 files changed

+487
-1328
lines changed

5 files changed

+487
-1328
lines changed

jest.config.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ module.exports = {
22
// Jest 24 defaults to JSDOM 11, upgrade to 15 to support canvas@2
33
testEnvironment: 'jest-environment-jsdom-fifteen',
44
setupFilesAfterEnv: [
5-
// configure enzyme w/ react adapter
6-
'<rootDir>/test/config/configure-enzyme.js',
75
// polyfill window.resizeTo
86
'window-resizeto/polyfill'
97
],

0 commit comments

Comments
 (0)