Field alias - first try #146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matt
I creates this PR for you to check out what I have done to date. I'm not entirely sure that is what you were looking for but it covers what I was thinking. This is meant to be a prelim version as there is still a bunch of commented code left behind.
The biggest challenge was dealing with the two mnemonic case, ie the DREF/EREF example (there are two more that I created).
I also created the field_alias param as part of the from_las/from_lasio methods. However, it would entirely replace the existing location dict , rather than adding or appending to the existing. Not sure if that is a good ides or not. I didnt add the "strict" option yet as I wanted your feedback first.
This PR passed all unit tests.
Let me know what you think.
Corey Hooge