Skip to content

Commit 7e41afd

Browse files
authored
release notes fixes (#79)
1 parent dffb6f0 commit 7e41afd

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ jobs:
3737
echo "Getting release notes for $REPO version $VERSION"
3838
3939
# Get release notes
40-
release_notes=$(gh release view $VERSION --repo $REPO --json body | jq '.body')
41-
echo "::set-output name=release_notes::${release_notes}"
40+
gh release view $VERSION --repo $REPO --json body | jq -r '.body' >> release_notes.txt
4241
4342
echo "Downloading artifact from $REPO version $VERSION"
4443
@@ -69,11 +68,10 @@ jobs:
6968

7069
- name: Open pull request
7170
run: |
72-
gh pr create --title "Update to Firebase $VERSION" --body "$RELEASE_NOTES" --base main --head release/$VERSION
71+
gh pr create --title "Update to Firebase $VERSION" --body-file release_notes.txt --base main --head release/$VERSION
7372
echo "::set-output name=number::${number}"
7473
env:
7574
VERSION: ${{ steps.extract_version.outputs.version }}
76-
RELEASE_NOTES: ${{ steps.download_artifact.outputs.release_notes }}
7775
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7876

7977
- name: Approve pull request

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,12 @@ jobs:
9393

9494
echo "Creating a release for version $version"
9595

96-
release_notes=$(gh release view $VERSION --repo $FIREBASE_REPO --json body | jq '.body')
96+
gh release view $VERSION --repo $FIREBASE_REPO --json body | jq -r '.body' >> release_notes.txt
9797

9898
# Create a new release
9999
gh release create $version ./artifacts/* \
100100
--title "$version" \
101-
--notes "$release_notes"
101+
--notes-file release_notes.txt
102102
fi
103103

104104
env:

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ playground.xcworkspace
4040
# ignore distribution files
4141
dist/
4242
artifacts/
43+
release_notes.txt
4344

4445
# ignore swift package manager files
4546
.swiftpm/

0 commit comments

Comments
 (0)