Skip to content

Fatal error on selfTest #67

@bessone

Description

@bessone

Hello,

in my project (with Guzzle 7.9.2) selfTest fails when the domain is not configured on the dns.

In the selfHttpTest method the error is checked in a try catch block, but the exception caught is GuzzleHttp\Exception\RequestException

protected function selfHttpTest(Authorization $authorization, $maxAttempts)

instead I get the exception GuzzleHttp\Exception\ConnectException

[object] (GuzzleHttp\\Exception\\ConnectException(code: 0): cURL error 6: Could not resolve host: domain.tld (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for http://domain.tld/.well-known/acme-challenge/tio8iBrKrML3qvNZsDnGvgmcrVXX-GpjxDH25Zfi3ZY

this causes an error to occur, unless I catch it in my code.

I don't know if Guzzle 7 returns a different exception than Guzzle 6, I thought about doing a PR to catch both exceptions, but the multiple catch is only present from PHP > 7.1 and this project does not have a limitation on the PHP version, so for those who still use PHP < 7.1 it would become incompatible.

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions