Skip to content

Commit cf4bf29

Browse files
authored
refactor dummy to naive (#2831)
1 parent 11183c0 commit cf4bf29

File tree

5 files changed

+16
-13
lines changed

5 files changed

+16
-13
lines changed

aeon/forecasting/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
"""Forecasters."""
22

33
__all__ = [
4-
"DummyForecaster",
4+
"NaiveForecaster",
55
"BaseForecaster",
66
"RegressionForecaster",
77
"ETSForecaster",
88
]
99

10-
from aeon.forecasting._dummy import DummyForecaster
1110
from aeon.forecasting._ets import ETSForecaster
11+
from aeon.forecasting._naive import NaiveForecaster
1212
from aeon.forecasting._regression import RegressionForecaster
1313
from aeon.forecasting.base import BaseForecaster

aeon/forecasting/_dummy.py renamed to aeon/forecasting/_naive.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
1-
"""DummyForecaster always predicts the last value seen in training."""
1+
"""Naive Forecaster."""
22

33
from aeon.forecasting.base import BaseForecaster
44

55

6-
class DummyForecaster(BaseForecaster):
7-
"""Dummy forecaster always predicts the last value seen in training."""
6+
class NaiveForecaster(BaseForecaster):
7+
"""Naive forecaster that always predicts the last value seen in training."""
88

99
def __init__(self):
10-
"""Initialize DummyForecaster."""
10+
"""Initialize NaiveForecaster."""
1111
self.last_value_ = None
1212
super().__init__(horizon=1, axis=1)
1313

1414
def _fit(self, y, exog=None):
15-
"""Fit dummy forecaster."""
15+
"""Fit Naive forecaster."""
1616
y = y.squeeze()
1717
self.last_value_ = y[-1]
1818
return self
1919

2020
def _predict(self, y=None, exog=None):
21-
"""Predict using dummy forecaster."""
21+
"""Predict using Naive forecaster."""
2222
return self.last_value_
2323

2424
def _forecast(self, y, exog=None):

aeon/forecasting/base.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
55
"""
66

7+
__maintainer__ = ["TonyBagnall"]
8+
__all__ = ["BaseForecaster"]
9+
710
from abc import abstractmethod
811

912
import numpy as np

aeon/forecasting/tests/test_base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
import pandas as pd
55
import pytest
66

7-
from aeon.forecasting import DummyForecaster
7+
from aeon.forecasting import NaiveForecaster
88

99

1010
def test_base_forecaster():
1111
"""Test base forecaster functionality."""
12-
f = DummyForecaster()
12+
f = NaiveForecaster()
1313
y = np.random.rand(50)
1414
f.fit(y)
1515
p1 = f.predict()
@@ -26,7 +26,7 @@ def test_base_forecaster():
2626

2727
def test_convert_y():
2828
"""Test y conversion in forecasting base."""
29-
f = DummyForecaster()
29+
f = NaiveForecaster()
3030
y = np.random.rand(50)
3131
with pytest.raises(ValueError, match="Input axis should be 0 or 1"):
3232
f._convert_y(y, axis=2)

examples/forecasting/forecasting.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,9 @@
193193
"cell_type": "code",
194194
"source": [
195195
"# Fit then predict\n",
196-
"from aeon.forecasting import DummyForecaster\n",
196+
"from aeon.forecasting import NaiveForecaster\n",
197197
"\n",
198-
"d = DummyForecaster()\n",
198+
"d = NaiveForecaster()\n",
199199
"print(d.get_tag(\"y_inner_type\"))\n",
200200
"d.fit(y)\n",
201201
"p = d.predict()\n",

0 commit comments

Comments
 (0)