From 8e6e165cb03a1494893971de43a145e92abbb220 Mon Sep 17 00:00:00 2001 From: Chad Bentz <1760475+felickz@users.noreply.github.com> Date: Fri, 25 Oct 2024 13:00:28 -0400 Subject: [PATCH 1/6] Update index.ts if (err != null) throw err --- packages/babel-helpers/src/index.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/babel-helpers/src/index.ts b/packages/babel-helpers/src/index.ts index be7b2c4198..ed68a3d013 100644 --- a/packages/babel-helpers/src/index.ts +++ b/packages/babel-helpers/src/index.ts @@ -8,6 +8,7 @@ type GetDependency = (name: string) => t.Expression; function deep(obj: any, path: string, value?: unknown) { try { const parts = path.split("."); + if (err != null) throw err let last = parts.shift(); while (parts.length > 0) { obj = obj[last]; From 2723735c0b7b84a56167548bca7e37bc106797cc Mon Sep 17 00:00:00 2001 From: Chad Bentz <1760475+felickz@users.noreply.github.com> Date: Fri, 25 Oct 2024 13:14:49 -0400 Subject: [PATCH 2/6] folder without wildcard in sparse checkout --- .github/workflows/codeql-monorepo.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/codeql-monorepo.yml b/.github/workflows/codeql-monorepo.yml index bd92bdace9..41676ee401 100644 --- a/.github/workflows/codeql-monorepo.yml +++ b/.github/workflows/codeql-monorepo.yml @@ -39,7 +39,7 @@ jobs: uses: actions/checkout@v4 with: fetch-depth: 1 - sparse-checkout: "packages/*" + sparse-checkout: "packages/" # EX: # { # "javascript": { From 5f0dd7f70398cb3a1695b1fb08ece19fc5f34dc9 Mon Sep 17 00:00:00 2001 From: Chad Bentz <1760475+felickz@users.noreply.github.com> Date: Fri, 25 Oct 2024 17:42:31 +0000 Subject: [PATCH 3/6] fix typo! --- packages/babel-helpers/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/babel-helpers/src/index.ts b/packages/babel-helpers/src/index.ts index ed68a3d013..bf48f16475 100644 --- a/packages/babel-helpers/src/index.ts +++ b/packages/babel-helpers/src/index.ts @@ -8,7 +8,7 @@ type GetDependency = (name: string) => t.Expression; function deep(obj: any, path: string, value?: unknown) { try { const parts = path.split("."); - if (err != null) throw err + if (parts != null) throw parts let last = parts.shift(); while (parts.length > 0) { obj = obj[last]; From 11a2c613ad3a611da41df77b80fa4ce06f1a0df1 Mon Sep 17 00:00:00 2001 From: Chad Bentz <1760475+felickz@users.noreply.github.com> Date: Fri, 25 Oct 2024 19:15:48 +0000 Subject: [PATCH 4/6] merge --- .github/workflows/codeql-monorepo.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/codeql-monorepo.yml b/.github/workflows/codeql-monorepo.yml index 3bc4865e26..a1ef83cd6b 100644 --- a/.github/workflows/codeql-monorepo.yml +++ b/.github/workflows/codeql-monorepo.yml @@ -101,4 +101,4 @@ jobs: uses: advanced-security/monorepo-code-scanning-action/republish-sarif@main with: projects: ${{ needs.changes.outputs.projects }} - merged-only: true +# merged-only: true From d2cda2d7c1895724aebb9960f8917814c1055161 Mon Sep 17 00:00:00 2001 From: Chad Bentz <1760475+felickz@users.noreply.github.com> Date: Fri, 25 Oct 2024 15:29:54 -0400 Subject: [PATCH 5/6] Get rid of IF temporarily --- .github/workflows/codeql-monorepo.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/codeql-monorepo.yml b/.github/workflows/codeql-monorepo.yml index 25d5e2e3e5..c4450d3488 100644 --- a/.github/workflows/codeql-monorepo.yml +++ b/.github/workflows/codeql-monorepo.yml @@ -74,7 +74,7 @@ jobs: projects-json: monorepo-projects.json scan: - if: needs.changes.outputs.scan-required == true + #if: needs.changes.outputs.scan-required == true runs-on: ubuntu-latest permissions: contents: read From 200872f1813ce2890132a632e12a9c8167e1edde Mon Sep 17 00:00:00 2001 From: Chad Bentz <1760475+felickz@users.noreply.github.com> Date: Fri, 25 Oct 2024 16:58:00 -0400 Subject: [PATCH 6/6] Update codeql-monorepo.yml --- .github/workflows/codeql-monorepo.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/codeql-monorepo.yml b/.github/workflows/codeql-monorepo.yml index c4450d3488..97334fb1a1 100644 --- a/.github/workflows/codeql-monorepo.yml +++ b/.github/workflows/codeql-monorepo.yml @@ -32,6 +32,7 @@ jobs: contents: read outputs: projects: ${{ steps.changes.outputs.projects }} + scan-required: ${{ steps.changes.outputs.scan-required }} steps: # # Only checkout the latest commit and just the packages folder # - name: Checkout repository @@ -73,8 +74,12 @@ jobs: with: projects-json: monorepo-projects.json + - name: Print scan-required output + run: | + echo "Scan Required: ${{ steps.changes.outputs.scan-required }}" + scan: - #if: needs.changes.outputs.scan-required == true + if: needs.changes.outputs.scan-required == true runs-on: ubuntu-latest permissions: contents: read