Skip to content

Commit 2a26e7e

Browse files
committed
(fix) remove message divider after new message
1 parent de5497b commit 2a26e7e

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

src/ChatWindow/Message/Message.vue

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -277,22 +277,16 @@ export default {
277277
278278
watch: {
279279
newMessages(val) {
280-
if (!val.length || !this.showNewMessagesDivider) return
280+
if (!val.length || !this.showNewMessagesDivider) {
281+
return (this.newMessage = {})
282+
}
283+
281284
this.newMessage = val.reduce((res, obj) =>
282285
obj.index < res.index ? obj : res
283286
)
284287
}
285288
},
286289
287-
mounted() {
288-
if (!this.message.seen && this.message.senderId !== this.currentUserId) {
289-
this.$emit('add-new-message', {
290-
_id: this.message._id,
291-
index: this.index
292-
})
293-
}
294-
},
295-
296290
methods: {
297291
onHoverMessage() {
298292
this.imageHover = true

src/ChatWindow/Room/Room.vue

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@
8787
@message-action-handler="messageActionHandler"
8888
@open-file="openFile"
8989
@open-user-tag="openUserTag"
90-
@add-new-message="addNewMessage"
9190
@send-message-reaction="sendMessageReaction"
9291
@hide-options="hideOptions = $event"
9392
>
@@ -468,12 +467,23 @@ export default {
468467
}
469468
},
470469
messages(newVal, oldVal) {
471-
newVal.forEach(message => {
470+
newVal.forEach((message, i) => {
472471
if (!messagesValid(message)) {
473472
throw new Error(
474473
'Messages object is not valid! Must contain _id[String, Number], content[String, Number] and senderId[String, Number]'
475474
)
476475
}
476+
477+
if (
478+
this.showNewMessagesDivider &&
479+
!message.seen &&
480+
message.senderId !== this.currentUserId
481+
) {
482+
this.newMessages.push({
483+
_id: message._id,
484+
index: i
485+
})
486+
}
477487
})
478488
479489
const element = this.$refs.scrollContainer
@@ -487,6 +497,7 @@ export default {
487497
}
488498
489499
if (oldVal && newVal && oldVal.length === newVal.length - 1) {
500+
this.newMessages = []
490501
this.loadingMessages = false
491502
492503
if (this.getBottomScroll(element) < 60) {
@@ -690,9 +701,6 @@ export default {
690701
width: this.$refs.mediaFile.clientWidth + 26
691702
}
692703
},
693-
addNewMessage(message) {
694-
this.newMessages.push(message)
695-
},
696704
escapeTextarea() {
697705
if (this.filteredEmojis.length) this.filteredEmojis = []
698706
else if (this.filteredUsersTag.length) this.filteredUsersTag = []

0 commit comments

Comments
 (0)