refactor(addon/components/paper-button): uses this.parent and documents parent types.

matthewhartstonge · matthewhartstonge · commit 3766f76d20d3 · 2024-11-14T01:50:49.000+13:00
diff --git a/addon/components/paper-button.js b/addon/components/paper-button.js
@@ -17,7 +17,7 @@ export default class PaperButton extends Focusable {
   element;
   /**
    * The parent this component is bound to.
-   * @type {Boolean}
+   * @type {PaperForm|PaperItem|PaperTabs}
    */
   parent;
   /**
@@ -54,7 +54,7 @@ export default class PaperButton extends Focusable {
     this.registerListeners(element);
 
     if (this.shouldRegister) {
-      this.args.parentComponent.registerChild(this);
+      this.parent.registerChild(this);
     }
   }
 
@@ -77,7 +77,7 @@ export default class PaperButton extends Focusable {
     super.willDestroy(...arguments);
 
     if (this.shouldRegister) {
-      this.args.parentComponent.unregisterChild(this);
+      this.parent.unregisterChild(this);
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ export default class PaperButton extends Focusable {`
`17`	`17`	`element;`
`18`	`18`	`/**`
`19`	`19`	`* The parent this component is bound to.`
`20`		`- * @type {Boolean}`
	`20`	`+ * @type {PaperForm\|PaperItem\|PaperTabs}`
`21`	`21`	`*/`
`22`	`22`	`parent;`
`23`	`23`	`/**`
`@@ -54,7 +54,7 @@ export default class PaperButton extends Focusable {`
`54`	`54`	`this.registerListeners(element);`
`55`	`55`
`56`	`56`	`if (this.shouldRegister) {`
`57`		`- this.args.parentComponent.registerChild(this);`
	`57`	`+ this.parent.registerChild(this);`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`
`@@ -77,7 +77,7 @@ export default class PaperButton extends Focusable {`
`77`	`77`	`super.willDestroy(...arguments);`
`78`	`78`
`79`	`79`	`if (this.shouldRegister) {`
`80`		`- this.args.parentComponent.unregisterChild(this);`
	`80`	`+ this.parent.unregisterChild(this);`
`81`	`81`	`}`
`82`	`82`	`}`
`83`	`83`