Shutdown Order for clean shutdowns

[nidomiro]

Hi,
I'm coming from an enterprise nestjs application and want to try out adonisJS.
One big challenge we faced there was doing a clean graceful shutdown in nestjs, so I want to explore this topic with adonisjs.

Let's say I have an application that connects to a service to receive messages. These messages are processed and stored to a db.
On shutdown the connection to the message-service needs to be closed first, then, after every message that is still in the app is processed, the db connection needs to be closed. In this case the db-connection does need to stay open until the processing finished.
How can I model such behavior in adonisJS?

With providers I get a shutdown-hook, but the execution order is wrong:
When the providers are initialized in this order: A -> B -> C the shutdown needs to be in C -> B -> A. Right now adonisjs runs the shutdown-hooks in the same order as the initialization.
On the other hand Providers only register stuff e.g. in the DI-system. In the DI-system we have a graph of dependencies, and who needs what. But is there a way to "invert" that graph and shutdown the dependencies in order?

[thetutlage]

Hello 👋

I think executing the shutdown in the reverse order does make sense. That is how we run our hooks in the rest of the application.

So, does reversing the process alone is enough for your use-case or are you looking for something else as well?

[thetutlage]

@RomainLanz I am thinking of introducing a feature flag called next in adonisrc.ts file and then we can start baking new features into the existing version without breaking anything.

For example, we would have next.executeShutdownHooksInReverse will enable this behavior, which will be part of next release without this flag

What do you think?

[RomainLanz]

Yes, introducing flags to enable upcoming breaking changes is a good idea. I’d suggest naming it experimental instead of next. This would give us more flexibility to test features without necessarily committing them to the next release. It’s also consistent with how other frameworks like Nuxt handle similar cases.

[thetutlage]

Cool. Experimental sounds good too.

[thetutlage]

@nidomiro Here you go. https://github.com/adonisjs/application/releases/tag/v8.4.0

[nidomiro]

Thanks :) and sorry for the late reply.

I tested it and it worked as expected, thanks 👍