[lucid] Don't throw when arg is undefined (find and findBy)

[tianjos]

Hey 👋

I would like to share my thought about throwing an error when args of this methods (find and findBy) are undefined

Since there are already explicit methods that do this (findByOrFail and findOrFail), wouldn't it make more sense to allow the caller to decide whether to throw or not?

This would avoid checking whether a given value is nullish to perform this type of operation and make the code more concise.

Let me know if this is valid for open a PR

[thetutlage]

Isn't it a programmatic error that you send undefined to the find or findBy method? In that case, it does make sense to throw and let the user fix the code or add needed conditionals.

[tianjos]

Hi and thanks for the reply!

First, I would call it design decision instead of programmatic error, since call db could result in undefined and this would be handle by client anyway.

My point is that if you have an explicitly API that throws an error the another one wouldn't never throws. In sense of, naming things, makes design more accurate.

From the client's point of view, it is not clear that the API can throw an error. The client needs to see the code base to understand it.

For the sake of clarity makes more sense that find and findBy fails silently given nullable args

[thetutlage]

I don't think this is a design decision, because why would you want to search the database with undefined values?

Also, any function could throw errors. For example, the same function could throw error when there is database connection issue or if some column is missing in the database.