-
Notifications
You must be signed in to change notification settings - Fork 1.2k
useCalendarState start date doesn't recalculate when updating visibleDuration #7809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I must have missed this somehow when looking for any duplicates of #7876, sorry about that! I think what you have is promising, would you like to also try to add |
Hi @LFDanLu , I'm trying to open a PR for this but am unable to push to the repo. Can you help? |
Sure, did you make a fork of the repo from which you are trying to open the PR? |
i just pulled the repo and made a branch. Is there any documentation on the process? |
We have https://react-spectrum.adobe.com/contribute.html#pull-requests, but feel free to let me know if you have any additional questions! |
That should be fine or you could add a test to |
Provide a general summary of the issue here
I'm creating a mobile calendar and when I scroll up I want to add the previous months. I am doing this by increasing the visibleDuration.
When the visibleMonths is updated the value of the
startDate
is not recalculated and therefore my calendar never goes before the initial startDate.🤔 Expected Behavior?
When updating
visibleDuration
thestartDate
will be recalculated.😯 Current Behavior
When updating
visibleDuration
thestartDate
is not recalculated.💁 Possible Solution
I have copied the source code and amended locally and made the change below
Before:
After:
If you would like me to open a PR let me know and I can also create a CodeSandbox or similar to show.
🔦 Context
No response
🖥️ Steps to Reproduce
to follow
Version
3.6.0
What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
MacOS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response
The text was updated successfully, but these errors were encountered: