How does resetValidation() work?

[nwidynski]

Hey 👋 ,

I'm currently working my way through the react-stately library and have a question regarding the implementation of the useFormValidationState() hook.

Why is the equal check of resetValidation() ran against lastError instead of the current validity? The comment above the line seems to imply a desire to display immediate change, which this won't do?

react-spectrum/packages/@react-stately/form/src/useFormValidationState.ts

Lines 161 to 167 in a3d77ab

	// Update the currently displayed validation state to valid on form reset,
	// even if the native validity says it isn't. It'll show again on the next form submit.
	let error = DEFAULT_VALIDATION_RESULT;
	if (!isEqualValidation(error, lastError.current)) {
	lastError.current = error;
	setCurrentValidity(error);
	}

Wouldn't it make more sense to look something like this:

// Update the currently displayed validation state to valid on form reset,
// even if the native validity says it isn't. It'll show again on the next form submit.
let error = DEFAULT_VALIDATION_RESULT;
if (!isEqualValidation(error, currentValidity)) {
    lastError.current = currentValidity;
    setCurrentValidity(error);
}