should InlineAlert have a Header or a Heading (or both)?
#4823
-
|
it seems the spectrum docs say there should be "an extra-extra-small heading component" (see https://spectrum.adobe.com/page/in-line-alert/#Title-area), but the current react-spectrum implementation wants a |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
I think this is a good point. Heading is for text, whereas Header is more of a container. Update: On the other hand, InlineAlert has Content which is a container, so maybe it makes more since to pair that with Header? I'll bring this up with the team. |
Beta Was this translation helpful? Give feedback.
-
|
Looks like this is the correct change. I've made a PR here: #4834 |
Beta Was this translation helpful? Give feedback.
Looks like this is the correct change. I've made a PR here: #4834