Release Audit (#5594)

Author: devongovett

packages/@react-aria/tabs/src/TabsKeyboardDelegate.ts

@@ -47,15 +47,15 @@ export class TabsKeyboardDelegate<T> implements KeyboardDelegate {
 
   getFirstKey() {
     let key = this.collection.getFirstKey();
-    if (key && this.disabledKeys.has(key)) {
+    if (key != null && this.disabledKeys.has(key)) {
       key = this.getNextKey(key);
     }
     return key;
   }
 
   getLastKey() {
     let key = this.collection.getLastKey();
-    if (key && this.disabledKeys.has(key)) {
+    if (key != null && this.disabledKeys.has(key)) {
       key = this.getPreviousKey(key);
     }
     return key;

packages/dev/docs/src/PropTable.js

@@ -117,6 +117,10 @@ function groupProps(props) {
       }
 
       if (props[propName]) {
+        if (propName === 'id' && props[propName].value.type !== 'string') {
+          continue;
+        }
+
         groupProps[propName] = props[propName];
         delete props[propName];
       }

packages/dev/docs/src/StateTable.js

@@ -22,13 +22,14 @@ export function StateTable({properties, showOptional}) {
   if (!showOptional) {
     props = props.filter(prop => !prop.optional);
   }
+  let showSelector = props.some(prop => prop.selector);
 
   return (
     <table className={`${tableStyles['spectrum-Table']} ${styles.propTable}`}>
       <thead>
         <tr>
           <td role="columnheader" className={tableStyles['spectrum-Table-headCell']}>Name</td>
-          <td role="columnheader" className={tableStyles['spectrum-Table-headCell']}>CSS Selector</td>
+          {showSelector && <td role="columnheader" className={tableStyles['spectrum-Table-headCell']}>CSS Selector</td>}
           <td role="columnheader" className={tableStyles['spectrum-Table-headCell']}>Description</td>
         </tr>
       </thead>
@@ -40,11 +41,11 @@ export function StateTable({properties, showOptional}) {
                 <span className="token hljs-variable">{prop.name}</span>
               </code>
             </td>
-            <td role="rowheader" className={clsx(tableStyles['spectrum-Table-cell'], styles.tableCell)} data-column="CSS Selector">
+            {showSelector && <td role="rowheader" className={clsx(tableStyles['spectrum-Table-cell'], styles.tableCell)} data-column="CSS Selector">
               <code className={`${typographyStyles['spectrum-Code4']}`}>
                 <span className={prop.selector ? 'token hljs-string' : null}>{prop.selector || '—'}</span>
               </code>
-            </td>
+            </td>}
             <td className={clsx(tableStyles['spectrum-Table-cell'], styles.tableCell)}>{renderHTMLfromMarkdown(prop.description, {forceInline: false})}</td>
           </tr>
         ))}

packages/react-aria-components/src/Checkbox.tsx

@@ -19,7 +19,7 @@ import React, {createContext, ForwardedRef, forwardRef, useContext, useRef} from
 import {TextContext} from './Text';
 
 export interface CheckboxGroupProps extends Omit<AriaCheckboxGroupProps, 'children' | 'label' | 'description' | 'errorMessage' | 'validationState' | 'validationBehavior'>, RACValidation, RenderProps<CheckboxGroupRenderProps>, SlotProps {}
-export interface CheckboxProps extends Omit<AriaCheckboxProps, 'children' | 'validationState'>, HoverEvents, RACValidation, RenderProps<CheckboxRenderProps>, SlotProps {}
+export interface CheckboxProps extends Omit<AriaCheckboxProps, 'children' | 'validationState' | 'validationBehavior'>, HoverEvents, RACValidation, RenderProps<CheckboxRenderProps>, SlotProps {}
 
 export interface CheckboxGroupRenderProps {
   /**

packages/react-aria-components/src/Collection.tsx

@@ -900,7 +900,7 @@ export interface SectionProps<T> extends Omit<SharedSectionProps<T>, 'children'
   value?: T,
   /** Static child items or a function to render children. */
   children?: ReactNode | ((item: T) => ReactElement),
-  /** Values that should invalidate the column cache when using dynamic collections. */
+  /** Values that should invalidate the item cache when using dynamic collections. */
   dependencies?: any[]
 }
 

packages/react-aria-components/src/DatePicker.tsx

@@ -62,7 +62,7 @@ export interface DateRangePickerRenderProps extends Omit<DatePickerRenderProps,
   state: DateRangePickerState
 }
 
-export interface DatePickerProps<T extends DateValue> extends Omit<AriaDatePickerProps<T>, 'label' | 'description' | 'errorMessage' | 'validationState'>, Pick<DatePickerStateOptions<T>, 'shouldCloseOnSelect'>, RACValidation, RenderProps<DatePickerRenderProps>, SlotProps {}
+export interface DatePickerProps<T extends DateValue> extends Omit<AriaDatePickerProps<T>, 'label' | 'description' | 'errorMessage' | 'validationState' | 'validationBehavior'>, Pick<DatePickerStateOptions<T>, 'shouldCloseOnSelect'>, RACValidation, RenderProps<DatePickerRenderProps>, SlotProps {}
 export interface DateRangePickerProps<T extends DateValue> extends Omit<AriaDateRangePickerProps<T>, 'label' | 'description' | 'errorMessage' | 'validationState' | 'validationBehavior'>, Pick<DateRangePickerStateOptions<T>, 'shouldCloseOnSelect'>, RACValidation, RenderProps<DateRangePickerRenderProps>, SlotProps {}
 
 export const DatePickerContext = createContext<ContextValue<DatePickerProps<any>, HTMLDivElement>>(null);

packages/react-aria-components/src/Slider.tsx

@@ -210,7 +210,7 @@ export interface SliderThumbRenderProps {
   isDisabled: boolean
 }
 
-export interface SliderThumbProps extends Omit<AriaSliderThumbProps, 'validationState'>, HoverEvents, RenderProps<SliderThumbRenderProps> {}
+export interface SliderThumbProps extends Omit<AriaSliderThumbProps, 'label' | 'validationState'>, HoverEvents, RenderProps<SliderThumbRenderProps> {}
 
 function SliderThumb(props: SliderThumbProps, ref: ForwardedRef<HTMLDivElement>) {
   let state = useContext(SliderStateContext)!;

packages/react-aria-components/src/Table.tsx

@@ -529,6 +529,7 @@ export interface ColumnRenderProps {
 }
 
 export interface ColumnProps extends RenderProps<ColumnRenderProps> {
+  /** The unique id of the column. */
   id?: Key,
   /** Whether the column allows sorting. */
   allowsSorting?: boolean,
@@ -588,6 +589,7 @@ export {_TableBody as TableBody};
 export interface RowRenderProps extends ItemRenderProps {}
 
 export interface RowProps<T> extends StyleRenderProps<RowRenderProps>, LinkDOMProps {
+  /** The unique id of the row. */
   id?: Key,
   /** A list of columns used when dynamically rendering cells. */
   columns?: Iterable<T>,
@@ -649,6 +651,7 @@ export interface CellRenderProps {
 }
 
 export interface CellProps extends RenderProps<CellRenderProps> {
+  /** The unique id of the cell. */
   id?: Key,
   /** A string representation of the cell's contents, used for features like typeahead. */
   textValue?: string

packages/react-aria-components/src/Tabs.tsx

@@ -43,6 +43,7 @@ export interface TabListRenderProps {
 }
 
 export interface TabProps extends RenderProps<TabRenderProps>, AriaLabelingProps, LinkDOMProps {
+  /** The unique id of the tab. */
   id?: Key
 }
 

packages/react-aria-components/src/utils.tsx

@@ -75,6 +75,7 @@ export interface DOMProps extends StyleProps {
 }
 
 export interface ScrollableProps<T extends Element> {
+  /** Handler that is called when a user scrolls. See [MDN](https://developer.mozilla.org/en-US/docs/Web/API/Element/scroll_event). */
   onScroll?: (e: UIEvent<T>) => void
 }