Skip to content

Commit c961c55

Browse files
authored
Remove erroneous accessibility color contrast ignore rule (#5029)
investigated, turns out it is a legitimate color contrast problem
1 parent a39ac2f commit c961c55

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

.storybook/test-runner.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ module.exports = {
2020
await configureAxe(page, {
2121
// TODO: Ideally would have a selector target for the storybook's sb main body element
2222
rules: [
23-
{
24-
id: 'color-contrast',
25-
selector: 'body *:not([data-a11y-ignore="color-contrast"])'
26-
},
2723
{
2824
id: 'aria-hidden-focus',
2925
selector: 'body *:not([data-a11y-ignore="aria-hidden-focus"])',

packages/@react-spectrum/datepicker/src/DatePickerSegment.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@ function EditableSegment({segment, state}: DatePickerSegmentProps) {
6565
minWidth: segment.maxValue != null ? String(segment.maxValue).length + 'ch' : null
6666
}}
6767
data-testid={segment.type}>
68-
{/* TODO: double check this, color contrast issue with quiet placeholder */}
69-
<span data-a11y-ignore="color-contrast" aria-hidden="true" className={classNames(styles, 'react-spectrum-DatePicker-placeholder')}>{segment.placeholder}</span>
68+
<span aria-hidden="true" className={classNames(styles, 'react-spectrum-DatePicker-placeholder')}>{segment.placeholder}</span>
7069
{segment.isPlaceholder ? '' : segment.text}
7170
</div>
7271
);

0 commit comments

Comments
 (0)