Removing aria-disabled so TalkBack users can open the context dialog (#4710)

LFDanLu · web-flow · commit 66f96385aa5d · 2023-08-10T10:21:28.000-07:00
* Removing aria-disabled so TalkBack users can double tap to open the context dialog

* Updating aria-describedby label for unavailable menu items
diff --git a/packages/@react-spectrum/menu/intl/en-US.json b/packages/@react-spectrum/menu/intl/en-US.json
@@ -1,4 +1,4 @@
 {
     "moreActions": "More actions",
-    "unavailable": "Expand for details"
+    "unavailable": "Unavailable, expand for details"
 }
diff --git a/packages/@react-spectrum/menu/src/MenuItem.tsx b/packages/@react-spectrum/menu/src/MenuItem.tsx
@@ -96,9 +96,6 @@ export function MenuItem<T>(props: MenuItemProps<T>) {
     endProps.id = endId;
     menuItemProps['aria-describedby'] = [menuItemProps['aria-describedby'], endId].filter(Boolean).join(' ');
   }
-  if (isUnavailable) {
-    menuItemProps['aria-disabled'] = 'true';
-  }
 
   let contents = typeof rendered === 'string'
     ? <Text>{rendered}</Text>

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"moreActions": "More actions",`
`3`		`- "unavailable": "Expand for details"`
	`3`	`+ "unavailable": "Unavailable, expand for details"`
`4`	`4`	`}`
Original file line number	Diff line number	Diff line change
`@@ -96,9 +96,6 @@ export function MenuItem<T>(props: MenuItemProps<T>) {`
`96`	`96`	`endProps.id = endId;`
`97`	`97`	`menuItemProps['aria-describedby'] = [menuItemProps['aria-describedby'], endId].filter(Boolean).join(' ');`
`98`	`98`	`}`
`99`		`- if (isUnavailable) {`
`100`		`- menuItemProps['aria-disabled'] = 'true';`
`101`		`- }`
`102`	`99`
`103`	`100`	`let contents = typeof rendered === 'string'`
`104`	`101`	`? <Text>{rendered}</Text>`