Skip to content

Commit 52e04bc

Browse files
committed
Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac
2 parents 67423b2 + 22a9d27 commit 52e04bc

File tree

2 files changed

+453
-5
lines changed

2 files changed

+453
-5
lines changed

packages/@react-aria/collections/src/Document.ts

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,9 @@ export class BaseNode<T> {
140140
this.lastChild = child;
141141

142142
this.ownerDocument.markDirty(this);
143-
this.ownerDocument.queueUpdate();
143+
if (this.isConnected) {
144+
this.ownerDocument.queueUpdate();
145+
}
144146
}
145147

146148
insertBefore(newNode: ElementNode<T>, referenceNode: ElementNode<T>): void {
@@ -169,7 +171,9 @@ export class BaseNode<T> {
169171
newNode.parentNode = referenceNode.parentNode;
170172

171173
this.invalidateChildIndices(newNode);
172-
this.ownerDocument.queueUpdate();
174+
if (this.isConnected) {
175+
this.ownerDocument.queueUpdate();
176+
}
173177
}
174178

175179
removeChild(child: ElementNode<T>): void {
@@ -200,7 +204,9 @@ export class BaseNode<T> {
200204
child.index = 0;
201205

202206
this.ownerDocument.markDirty(child);
203-
this.ownerDocument.queueUpdate();
207+
if (this.isConnected) {
208+
this.ownerDocument.queueUpdate();
209+
}
204210
}
205211

206212
addEventListener(): void {}
@@ -331,7 +337,9 @@ export class ElementNode<T> extends BaseNode<T> {
331337
}
332338

333339
this.hasSetProps = true;
334-
this.ownerDocument.queueUpdate();
340+
if (this.isConnected) {
341+
this.ownerDocument.queueUpdate();
342+
}
335343
}
336344

337345
get style(): CSSProperties {

0 commit comments

Comments
 (0)