Skip to content

Commit 0fe0199

Browse files
authored
Remove express icon dep (#5130)
* Remove Express Icon dependency
1 parent 2aa1790 commit 0fe0199

File tree

5 files changed

+16
-29
lines changed

5 files changed

+16
-29
lines changed

packages/@adobe/spectrum-css-temp/vars/express.css

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,9 @@
103103
--spectrum-breadcrumb-item-padding-x: var(--spectrum-global-dimension-size-50);
104104
--spectrum-breadcrumb-separator-icon-position-adjustment: 0;
105105

106+
--spectrum-icon-chevron-right-small-height: var(--spectrum-global-dimension-size-225);
107+
--spectrum-icon-chevron-right-small-width: var(--spectrum-global-dimension-size-225);
108+
106109
--spectrum-combobox-fieldbutton-inset: var(--spectrum-global-dimension-size-75);
107110
--spectrum-combobox-fieldbutton-border-left-width: 0;
108111
--spectrum-combobox-fieldbutton-focus-ring-border-radius: var(--spectrum-alias-border-radius-regular);

packages/@react-spectrum/breadcrumbs/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
"@react-stately/collections": "^3.10.1",
4848
"@react-types/breadcrumbs": "^3.6.2",
4949
"@react-types/shared": "^3.20.0",
50-
"@spectrum-icons/express": "3.0.0-alpha.9",
5150
"@spectrum-icons/ui": "^3.5.5",
5251
"@swc/helpers": "^0.5.0"
5352
},

packages/@react-spectrum/breadcrumbs/src/BreadcrumbItem.tsx

Lines changed: 10 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
*/
1212

1313
import {BreadcrumbItemProps} from '@react-types/breadcrumbs';
14-
// eslint-disable-next-line monorepo/no-internal-import
15-
import ChevronRight from '@spectrum-icons/express/ChevronRight';
1614
import ChevronRightSmall from '@spectrum-icons/ui/ChevronRightSmall';
1715
import {classNames} from '@react-spectrum/utils';
1816
import {FocusRing} from '@react-aria/focus';
@@ -22,7 +20,6 @@ import styles from '@adobe/spectrum-css-temp/components/breadcrumb/vars.css';
2220
import {useBreadcrumbItem} from '@react-aria/breadcrumbs';
2321
import {useHover} from '@react-aria/interactions';
2422
import {useLocale} from '@react-aria/i18n';
25-
import {useProvider} from '@react-spectrum/provider';
2623

2724
interface SpectrumBreadcrumbItemProps extends BreadcrumbItemProps {
2825
isMenu?: boolean
@@ -35,7 +32,6 @@ export function BreadcrumbItem(props: SpectrumBreadcrumbItemProps) {
3532
isDisabled,
3633
isMenu
3734
} = props;
38-
let provider = useProvider();
3935

4036
let {direction} = useLocale();
4137
let ref = useRef(null);
@@ -70,29 +66,16 @@ export function BreadcrumbItem(props: SpectrumBreadcrumbItemProps) {
7066
{children}
7167
</ElementType>
7268
</FocusRing>
73-
{provider?.theme?.global?.express ? (
74-
<ChevronRight
75-
UNSAFE_className={
76-
classNames(
77-
styles,
78-
'spectrum-Breadcrumbs-itemSeparator',
79-
{
80-
'is-reversed': direction === 'rtl'
81-
}
82-
)
83-
} />
84-
) : (
85-
<ChevronRightSmall
86-
UNSAFE_className={
87-
classNames(
88-
styles,
89-
'spectrum-Breadcrumbs-itemSeparator',
90-
{
91-
'is-reversed': direction === 'rtl'
92-
}
93-
)
94-
} />
95-
)}
69+
<ChevronRightSmall
70+
UNSAFE_className={
71+
classNames(
72+
styles,
73+
'spectrum-Breadcrumbs-itemSeparator',
74+
{
75+
'is-reversed': direction === 'rtl'
76+
}
77+
)
78+
} />
9679
</Fragment>
9780
);
9881
}
Lines changed: 1 addition & 0 deletions
Loading

packages/@spectrum-icons/ui/scripts/generateIcons.cjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ const EXPRESS_ICON_MAPPING = {
2323
InfoSmall: 'SX_Info_14_S',
2424
SuccessMedium: 'SX_CheckmarkCircle_18_N',
2525
SuccessSmall: 'SX_CheckmarkCircle_14_S',
26-
FolderBreadcrumb: 'SX_More_18'
26+
FolderBreadcrumb: 'SX_More_18',
27+
ChevronRightSmall: 'SX_ChevronRight_18',
2728
};
2829

2930
let displayNameRegex = /.*?\.displayName = '(?<name>.*?)';/;

0 commit comments

Comments
 (0)