From 136960bbcd9774d107c2893534bf8a0134a1e2a9 Mon Sep 17 00:00:00 2001 From: Oliver Foster Date: Tue, 25 Mar 2025 18:58:52 +0000 Subject: [PATCH 1/2] Fix: Make _renderAsGroup as typegroup=group (fixes #212) --- js/BoxMenuModel.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/js/BoxMenuModel.js b/js/BoxMenuModel.js index 06cc613..6fee21e 100644 --- a/js/BoxMenuModel.js +++ b/js/BoxMenuModel.js @@ -1,3 +1,12 @@ import MenuModel from 'core/js/models/menuModel'; -export default class BoxMenuModel extends MenuModel {} +/** @typedef {import("core/js/models/adaptModel").default} AdaptModel */ + +export default class BoxMenuModel extends MenuModel { + + getTypeGroup() { + if (!this.get('_boxMenu')?._renderAsGroup) return; + return 'group'; + } + +} From bd848d16137078f33cb4d47d781cbd6b4700e780 Mon Sep 17 00:00:00 2001 From: Oliver Foster Date: Mon, 31 Mar 2025 15:17:17 +0100 Subject: [PATCH 2/2] Remove comment --- js/BoxMenuModel.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/js/BoxMenuModel.js b/js/BoxMenuModel.js index 6fee21e..a28cc60 100644 --- a/js/BoxMenuModel.js +++ b/js/BoxMenuModel.js @@ -1,7 +1,5 @@ import MenuModel from 'core/js/models/menuModel'; -/** @typedef {import("core/js/models/adaptModel").default} AdaptModel */ - export default class BoxMenuModel extends MenuModel { getTypeGroup() {