Skip to content

Commit cae6a8c

Browse files
fix baseadaptdeep
1 parent c6bb142 commit cae6a8c

File tree

1 file changed

+1
-32
lines changed

1 file changed

+1
-32
lines changed

adapt/base.py

Lines changed: 1 addition & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -300,37 +300,6 @@ def _check_params(self, params):
300300
(key, self.__class__.__name__, str(legal_params)))
301301

302302

303-
def _get_param_names(self):
304-
"""Get parameter names for the estimator"""
305-
# fetch the constructor or the original constructor before
306-
# deprecation wrapping if any
307-
init = getattr(self.__init__, "deprecated_original", self.__init__)
308-
if init is object.__init__:
309-
# No explicit constructor to introspect
310-
return []
311-
312-
# introspect the constructor arguments to find the model parameters
313-
# to represent
314-
init_signature = inspect.signature(init)
315-
# Consider the constructor parameters excluding 'self'
316-
parameters = [
317-
p
318-
for p in init_signature.parameters.values()
319-
if p.name != "self" and p.kind != p.VAR_KEYWORD
320-
]
321-
for p in parameters:
322-
if p.kind == p.VAR_POSITIONAL:
323-
raise RuntimeError(
324-
"scikit-learn estimators should always "
325-
"specify their parameters in the signature"
326-
" of their __init__ (no varargs)."
327-
" %s with constructor %s doesn't "
328-
" follow this convention." % ("dummy", init_signature)
329-
)
330-
# Extract and sort argument names excluding 'self'
331-
return sorted([p.name for p in parameters])
332-
333-
334303
def _filter_params(self, func, override={}, prefix=""):
335304
kwargs = {}
336305
args = inspect.getfullargspec(func).args
@@ -805,7 +774,7 @@ def _from_config_keras_model(self, dict_):
805774

806775

807776

808-
class BaseAdaptDeep(BaseAdapt, Model):
777+
class BaseAdaptDeep(Model, BaseAdapt):
809778

810779

811780
def __init__(self,

0 commit comments

Comments
 (0)