handling api version on request

[m-matth]

Hi !

i'm trying to manage multiple version of api in milena. Could be nice to have, because sometime it has a big impact, like OffsetCommit that can use zookeeper or kafka for storage depending on version used.

i'm testing to store the version in kafkaState, not sure if it the good aproach through :

m-matth@cdf3a49

i still had to find a way to constrain request/response data type to its own version.

[adamflott]

Yeah, now that I'm reinvesting my time into getting this library up to the latest protocol, I haven't thought of a good way to handle version(s) yet.

Your change does look like a move in the right direction. I wonder if it's worth investing in how to handle every version without duplicating code. I should look into how other popular implementations of their protocol handle this.

[m-matth]

you're right, code reduction can be left in a refactoring process with a clear view of protocol (and more skilled haskeller than i :).

will try to find time to finish the work on it, feel free to reuse it if you progress on the topic.

cheers