Skip to content

Commit 7b10b13

Browse files
committed
Tweak passed arguments
1 parent 872a3f5 commit 7b10b13

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

src/components/analogIO/Wippersnapper_AnalogIO.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ bool Wippersnapper_AnalogIO::encodePinEvent(
325325
*/
326326
/**********************************************************/
327327
void calculateHysteresis(analogInputPin pin, uint16_t pinValRaw,
328-
uint16_t pinValThreshHi, uint16_t pinValThreshLow) {
328+
uint16_t *pinValThreshHi, uint16_t *pinValThreshLow) {
329329
// All boards ADC values scaled to 16bit, in future we may need to
330330
// adjust dynamically
331331
uint16_t maxDecimalValue = 65535;
@@ -344,8 +344,8 @@ void calculateHysteresis(analogInputPin pin, uint16_t pinValRaw,
344344
}
345345

346346
// get the threshold values for previous pin value
347-
pinValThreshHi = pin.prvPinVal + CURRENT_HYSTERISIS;
348-
pinValThreshLow = pin.prvPinVal - CURRENT_HYSTERISIS;
347+
*pinValThreshHi = pin.prvPinVal + CURRENT_HYSTERISIS;
348+
*pinValThreshLow = pin.prvPinVal - CURRENT_HYSTERISIS;
349349
}
350350

351351
/**********************************************************/
@@ -425,8 +425,8 @@ void Wippersnapper_AnalogIO::update() {
425425

426426
// check if pin value has changed enough
427427
uint16_t pinValThreshHi, pinValThreshLow;
428-
calculateHysteresis(_analog_input_pins[i], pinValRaw, pinValThreshHi,
429-
pinValThreshLow);
428+
calculateHysteresis(_analog_input_pins[i], pinValRaw, &pinValThreshHi,
429+
&pinValThreshLow);
430430
WS_DEBUG_PRINT("Returned pinValThreshHi: ");
431431
WS_DEBUG_PRINTLN(pinValThreshHi);
432432
WS_DEBUG_PRINT("Returned pinValThreshLow: ");

src/components/analogIO/Wippersnapper_AnalogIO.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ class Wippersnapper_AnalogIO {
5757
int pin);
5858
void disableAnalogInPin(int pin);
5959

60-
void calculateHysteresis(analogInputPin pin, uint16_t pinValRaw,
61-
uint16_t pinValThreshHi, uint16_t pinValThreshLow);
6260
uint16_t getPinValue(int pin);
6361
float getPinValueVolts(int pin);
6462

0 commit comments

Comments
 (0)