dont erase bootlog unnecessarily, skip erase Circuitpython stuff

Author: tyeth

platformio.ini

@@ -91,7 +91,7 @@ lib_deps =
 ; Common build environment for ESP32 platform
 [common:esp32]
 platform = https://github.com/pioarduino/platform-espressif32/releases/download/51.03.07/platform-espressif32.zip
-; This is needed for occasional new features and bug fixes
+; develop branch is needed for occasional new features and bug fixes, main may be preferred
 ; platform = https://github.com/pioarduino/platform-espressif32#develop
 lib_ignore = WiFiNINA, WiFi101, OneWire
 monitor_filters = esp32_exception_decoder, time

src/provisioning/tinyusb/Wippersnapper_FS.cpp

@@ -159,14 +159,15 @@ bool Wippersnapper_FS::initFilesystem(bool force_format) {
   if (!wipperFatFs.begin(&flash))
     return false;
 
+if (false) { //TODO: reinstate after discussion over utility. Restest a full fs.
+
   //TODO: Don't do this unless we need the space and createSecrets fails
   // If CircuitPython was previously installed - erase CPY FS
   eraseCPFS();
+  // Also, should probably relabel drive to WIPPER if CIRCUITPY was there
+  // using setVolumeLabel(), but note the FS must be unmounted first
+}
 
-  //TODO: don't do this every time, only if content differs?
-  // If WipperSnapper was previously installed - remove the
-  // wippersnapper_boot_out.txt file
-  eraseBootFile();
 
   //TODO: don't do this every time, only if missing (less power usage? less block wear)
   // No file indexing on macOS
@@ -313,17 +314,30 @@ bool Wippersnapper_FS::createBootFile() {
 
     // Compare existing content with new content
     if (existingContent == newContent) {
+      WS_DEBUG_PRINTLN("INFO: wipper_boot_out.txt already exists with the "
+                        "same content.");
       return true; // No need to overwrite
+    } else {
+      WS_DEBUG_PRINTLN("INFO: wipper_boot_out.txt exists but with different "
+                        "content. Overwriting...");
     }
+  } else {
+    WS_DEBUG_PRINTLN("INFO: could not open wipper_boot_out.txt for reading. "
+                     "Creating new file...");
   }
 
+  // We probably don't need to erase first!
+  eraseBootFile();
+
   // Overwrite the file with new content
   bootFile = wipperFatFs.open("/wipper_boot_out.txt", FILE_WRITE);
   if (bootFile) {
     bootFile.print(newContent);
     bootFile.flush();
     bootFile.close();
     is_success = true;
+  } else {
+    WS_DEBUG_PRINTLN("ERROR: Unable to open wipper_boot_out.txt for writing!");
   }
 
   return is_success;

testplan.md

@@ -1,6 +1,18 @@
 copy and analyse the hex difference for a corrupted file system versus freshly saved secrets + hunky dorey
+-- nulls for file entry - like we've erased the file and then rebooted (before writing the replacement)
+-- we do a lot of unnecessary file writing each boot, I'm optimising that to only if needed so normally there will be no file writes
 
 retest first secrets.json acces on a new device on tinyUF2 0.18.2 and WS 88, versus tinyUF2 0.20.1 and WS88, then with no-ds-format-nor-file-recreation instead of WS88
+-- no-fs-format-nor-file-recreation branch has eliminated the issue
+
+Cleanup eraseCPFS and retest with full file system and no secrets + different bootlog contents. also move write bootlog after secrets processing if not already
+
+Add boot reason detection for brownouts, if so and corrupt secrets/FS then fsHalt with appropriate message for 30s then reboot.
+ Bad USB cables on first boot should be accounted for - brownout serial message / fsHalt
+
+As part of boot protection add message when write or erase attempt and suggest user manually perform action.
+ Secondly consider moving all serial debug output to after usb reattach so user sees it, or at least repeat?
+
 
 then add the metro-s3
 Update step images in ws_boards for metro-s3
@@ -10,4 +22,13 @@ then add FT usb-to-gpio to ws_python
 
 Test ws_boards c6-aVref branch (esp32 aref=1.1 instead of 3.3, and C6 from 1.1 to 2.5v)
 
-Fix pin numbers + names for Metro S2 (all digital etc, tx/rx and D1 [etc] seem wrong, analog5 is wrong etc)
+Fix pin numbers + names for Metro S2 (all digital etc, tx/rx and D1 [etc] seem wrong, analog5 is wrong etc)
+Add guide pages for wippersnapper on metro s2
+Add guide pages for WS on C6
+
+Check in on Marty's code / local mqtt issue.
+Look at exception handling in mqtt library which seems biggest user hurdle
+- consider capturing OSError etc and return mqtt exception?
+- look at how IO fails too
+- catch gai dns errors
+- see what happens when no response / waiting message during loop call (people report exception but actually valid to have empty response)