Skip to content

Commit 950fc6b

Browse files
authored
Merge pull request #53 from adafruit/develop
fix #52 mouseButtonRelease usage
2 parents 786bbc7 + 4a9477b commit 950fc6b

File tree

3 files changed

+24
-16
lines changed

3 files changed

+24
-16
lines changed

examples/MassStorage/msc_external_flash/msc_external_flash.ino

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,18 @@
2424
#include "Adafruit_SPIFlash.h"
2525
#include "Adafruit_TinyUSB.h"
2626

27-
#if defined(__SAMD51__) || defined(NRF52840_XXAA)
28-
Adafruit_FlashTransport_QSPI flashTransport(PIN_QSPI_SCK, PIN_QSPI_CS, PIN_QSPI_IO0, PIN_QSPI_IO1, PIN_QSPI_IO2, PIN_QSPI_IO3);
27+
// On-board external flash (QSPI or SPI) macros should already
28+
// defined in your board variant if supported
29+
// - EXTERNAL_FLASH_USE_QSPI
30+
// - EXTERNAL_FLASH_USE_CS/EXTERNAL_FLASH_USE_SPI
31+
#if defined(EXTERNAL_FLASH_USE_QSPI)
32+
Adafruit_FlashTransport_QSPI flashTransport;
33+
34+
#elif defined(EXTERNAL_FLASH_USE_SPI)
35+
Adafruit_FlashTransport_SPI flashTransport(EXTERNAL_FLASH_USE_CS, EXTERNAL_FLASH_USE_SPI);
36+
2937
#else
30-
#if (SPI_INTERFACES_COUNT == 1)
31-
Adafruit_FlashTransport_SPI flashTransport(SS, &SPI);
32-
#else
33-
Adafruit_FlashTransport_SPI flashTransport(SS1, &SPI1);
34-
#endif
38+
#error No QSPI/SPI flash are defined on your board variant.h !
3539
#endif
3640

3741
Adafruit_SPIFlash flash(&flashTransport);
@@ -73,7 +77,7 @@ void setup()
7377
fatfs.begin(&flash);
7478

7579
Serial.begin(115200);
76-
while ( !Serial ) delay(10); // wait for native usb
80+
//while ( !Serial ) delay(10); // wait for native usb
7781

7882
Serial.println("Adafruit TinyUSB Mass Storage External Flash example");
7983
Serial.print("JEDEC ID: "); Serial.println(flash.getJEDECID(), HEX);

examples/MassStorage/msc_external_flash_sdcard/msc_external_flash_sdcard.ino

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,18 @@
2424
#include "Adafruit_SPIFlash.h"
2525
#include "Adafruit_TinyUSB.h"
2626

27-
#if defined(__SAMD51__) || defined(NRF52840_XXAA)
28-
Adafruit_FlashTransport_QSPI flashTransport(PIN_QSPI_SCK, PIN_QSPI_CS, PIN_QSPI_IO0, PIN_QSPI_IO1, PIN_QSPI_IO2, PIN_QSPI_IO3);
27+
// On-board external flash (QSPI or SPI) macros should already
28+
// defined in your board variant if supported
29+
// - EXTERNAL_FLASH_USE_QSPI
30+
// - EXTERNAL_FLASH_USE_CS/EXTERNAL_FLASH_USE_SPI
31+
#if defined(EXTERNAL_FLASH_USE_QSPI)
32+
Adafruit_FlashTransport_QSPI flashTransport;
33+
34+
#elif defined(EXTERNAL_FLASH_USE_SPI)
35+
Adafruit_FlashTransport_SPI flashTransport(EXTERNAL_FLASH_USE_CS, EXTERNAL_FLASH_USE_SPI);
36+
2937
#else
30-
#if (SPI_INTERFACES_COUNT == 1)
31-
Adafruit_FlashTransport_SPI flashTransport(SS, &SPI);
32-
#else
33-
Adafruit_FlashTransport_SPI flashTransport(SS1, &SPI1);
34-
#endif
38+
#error No QSPI/SPI flash are defined on your board variant.h !
3539
#endif
3640

3741
Adafruit_SPIFlash flash(&flashTransport);

src/Adafruit_USBD_HID.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class Adafruit_USBD_HID : Adafruit_USBD_Interface {
6262
bool mouseMove(uint8_t report_id, int8_t x, int8_t y);
6363
bool mouseScroll(uint8_t report_id, int8_t scroll, int8_t pan);
6464
bool mouseButtonPress(uint8_t report_id, uint8_t buttons);
65-
static inline bool mouseButtonRelease(uint8_t report_id);
65+
bool mouseButtonRelease(uint8_t report_id);
6666

6767
// from Adafruit_USBD_Interface
6868
virtual uint16_t getDescriptor(uint8_t itfnum, uint8_t *buf,

0 commit comments

Comments
 (0)