Skip to content

Commit 569c83a

Browse files
authored
Merge pull request #179 from cmumford/fix-protected
Corrected client public/private methods.
2 parents 2f57277 + c5599bf commit 569c83a

File tree

2 files changed

+19
-14
lines changed

2 files changed

+19
-14
lines changed

Adafruit_MQTT_Client.h

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,14 @@ class Adafruit_MQTT_Client : public Adafruit_MQTT {
4141
const char *user = "", const char *pass = "")
4242
: Adafruit_MQTT(server, port, user, pass), client(client) {}
4343

44-
bool connectServer();
45-
bool disconnectServer();
46-
bool connected();
47-
uint16_t readPacket(uint8_t *buffer, uint16_t maxlen, int16_t timeout);
48-
bool sendPacket(uint8_t *buffer, uint16_t len);
44+
bool connected() override;
45+
46+
protected:
47+
bool connectServer() override;
48+
bool disconnectServer() override;
49+
uint16_t readPacket(uint8_t *buffer, uint16_t maxlen,
50+
int16_t timeout) override;
51+
bool sendPacket(uint8_t *buffer, uint16_t len) override;
4952

5053
private:
5154
Client *client;

Adafruit_MQTT_FONA.h

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,13 @@ class Adafruit_MQTT_FONA : public Adafruit_MQTT {
4242
const char *user = "", const char *pass = "")
4343
: Adafruit_MQTT(server, port, user, pass), fona(f) {}
4444

45-
bool connectServer() {
45+
bool connected() {
46+
// Return true if connected, false if not connected.
47+
return fona->TCPconnected();
48+
}
49+
50+
protected:
51+
bool connectServer() override {
4652
char server[40];
4753
strncpy(server, servername, 40);
4854
#ifdef ADAFRUIT_SLEEPYDOG_H
@@ -54,14 +60,10 @@ class Adafruit_MQTT_FONA : public Adafruit_MQTT {
5460
return fona->TCPconnect(server, portnum);
5561
}
5662

57-
bool disconnectServer() { return fona->TCPclose(); }
58-
59-
bool connected() {
60-
// Return true if connected, false if not connected.
61-
return fona->TCPconnected();
62-
}
63+
bool disconnectServer() override { return fona->TCPclose(); }
6364

64-
uint16_t readPacket(uint8_t *buffer, uint16_t maxlen, int16_t timeout) {
65+
uint16_t readPacket(uint8_t *buffer, uint16_t maxlen,
66+
int16_t timeout) override {
6567
uint8_t *buffp = buffer;
6668
DEBUG_PRINTLN(F("Reading data.."));
6769

@@ -114,7 +116,7 @@ class Adafruit_MQTT_FONA : public Adafruit_MQTT {
114116
return len;
115117
}
116118

117-
bool sendPacket(uint8_t *buffer, uint16_t len) {
119+
bool sendPacket(uint8_t *buffer, uint16_t len) override {
118120
DEBUG_PRINTLN(F("Writing packet"));
119121
if (fona->TCPconnected()) {
120122
boolean ret = fona->TCPsend((char *)buffer, len);

0 commit comments

Comments
 (0)