0.3.1

[ad-ha]

@ccpk1

Considering that some of the issues we have open and that were already fixed, I believe there's nothing else standing, aside from minor fixes on the due dates handling that you've mentioned, maybe we should release 0.3.1 to get those fixes out. Right?

If you also think that this is ok, unless you deem that the due date fixes are strictly necessary on this release, or you're able to sort those in the meanwhile, I would get out the update later today.

Let me know your thoughts.

Cheers

[ccpk1]

Unfortunately, some of my fixes for due dates were partially pulled in as part of the reward fixes I did over the weekend. I didn't realize after I submitted the pull request that additional changes I made in that branch would be pulled in, so lesson learned on my side. I'll always use a new branch per fix going forward. (I did that with the penalites and bonuses, so at least that was separate)

Given the due date changes are partially in, I think the best approach is to pull the rest of them in I just submitted, then make sure we're comfortable they are working as expected. I did quite a bit of individual scenario testing, so I feel good about the changes I submitted. Being forced to merge made me a little uncomfortable, but I spot checked several things and they looked to have kept my changes.

Only other thing I haven't done is watch any of the nightly resets or anything like that. Now that so much more is centralized, I'm pretty comfortable that the processing is working as expected.

Last thing I would ask you to take a brief look at is the way I handled the weekly reset for those chores that do not have a due_date, but are set with frequency of weekly. I think I handled it correctly, but would like a second opinion. Thanks!

[ad-ha]

Being forced to merge made me a little uncomfortable, but I spot checked several things and they looked to have kept my changes.

Sorry again for this. I did not realize that those were still pending things and messed with my new dev environment. Glad you were able to sort it out and get it fixed. Appreciate.

I will have a look into the pulls in a moment and check on the code. If I spot something I will let you know.

Cheers

[ad-ha]

Hi

It all seems ok and I have merged all commits now into main.

Just added some minor touches to services.py (replacing some constants that were still hard-coded) and updated translations en.json and es.json with the new services.

I will now prepare the release.

FYI. I just created now a new branch (https://github.com/ad-ha/kidschores-ha/tree/dev) so we may do next changes directly here and do it with separate commits for each thing that we may develop next. Seems fine this way?

[ccpk1]

Sounds good to me.

[ccpk1]

After considering it further, I plan to create a dev branch in my fork that tracks your repo’s main dev branch. I’ll do most of my work on feature branches based on that dev branch in my fork, and then merge completed changes back into dev as I reach logical milestones.

The approach might vary with different types of work, but my goal is to avoid leaving anything half-finished in dev, which could impact you. This is why I'll stick to a similar process as before, just with the base now being the dev branch.

[ad-ha]

That approach seems perfect, in line with what you comment on the issue thread.

I am still learning the ways about Github, but that sound quite the best way to go. 👍

Just made the release. It already available on HACS.

[ccpk1]

Overall things seemed to check out well. Thanks!