[Bug]: A sentence is missing in the translation repository

[harf4ng]

Verified issue does not already exist?

• I have searched and found no existing issue

What happened?

File: \packages\desktop-client\src\components\modals\ConfirmTransactionDeleteModal.tsx
Function: export function ConfirmTransactionDeleteModal({

Sentence :
message = 'Are you sure you want to delete the transaction?',

The message is missing a translation flag so it stays in english and no way we can translate it with weblate.

How can we reproduce the issue?

Just look at source code

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

Windows 11

[JonhyOliveira]

Hey @harf4ng

Couldn't find the exact path you are referring to in the issue. I just want to add a few links here to make it easier for the next one to parse through this.

I did find CofirmDeleteModal.tsx.

The title seems to be properly translated but the actual message is not translated. I assume this is the "message" you are referring to, right?

actual/packages/desktop-client/src/components/modals/ConfirmDeleteModal.tsx

Lines 38 to 45 in cccd667

	<>
	<ModalHeader
	title={t('Confirm Delete')}
	rightContent={<ModalCloseButton onPress={close} />}
	/>
	<View style={{ lineHeight: 1.5 }}>
	<Paragraph>{message}</Paragraph>
	<View

I need some guidance as to what a full fix for this would look like. Since adding t('Confirm Delete Transaction') would probably not be enough

[milanalexandre]

fixed by #5556

[harf4ng]

The ConfirmTransactionDeleteModal.tsx file is in the 25.8.0 branch.
Though according to milanalexandre it is fixed?

[JonhyOliveira]

@harf4ng, looking at the changes looks like ConfirmTransactionDeleteModal went away and is getting replaced by a more general ConfirmDeleteModal. The message is also now injected already translated in useTransactionBatchActions. This is what I could tell by looking at the PR patch diff at least.

Seems fixed at first glance

[harf4ng]

Ok thanks so this means we will have that in a new version anytime soon.