Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

[Bug]: Simplefin transactions do not follow goCardless sorting #556

@bvanelli

Description

@bvanelli

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When calculating the Starting Balance, the oldest transaction is taken as the last element of the list on the frontend:

https://github.com/actualbudget/actual/blob/f09f4af667ddd57e031dcdb0d428ae935aa2afad/packages/loot-core/src/server/accounts/sync.ts#L754-L759

But when using the simplefin integration, the sorting is not applied and the original sorting from their API is used, making the sorting newest -> oldest. This causes the frontend to create a starting balance dated to the youngest transaction, instead of the oldest as it should.

This can be reproduced quite quickly using the simplefin demo token:

Image

For goCardless, I could find some sorting, and this code could be used to also sort simpleFin transactions:

export const sortByBookingDateOrValueDate = (transactions = []) =>

What error did you receive?

No response

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Mac OSX

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions