Skip to content

Commit c3d697d

Browse files
server: Don't listen for SIGHUP (#389)
1 parent 80a3627 commit c3d697d

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

actix-server/CHANGES.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,13 @@
33
## Unreleased - 2021-xx-xx
44
* Remove `config` module. `ServiceConfig`, `ServiceRuntime` public types are removed due to this change. [#349]
55
* Remove `ServerBuilder::configure` [#349]
6+
* Server no long listens to SIGHUP signal.
7+
It actually did not take any action when receiving SIGHUP, the only thing SIGHUP did was to stop
8+
the Server from receiving any future signal, because the `Signals` future stops on the first
9+
signal received [#389]
610

711
[#349]: https://github.com/actix/actix-net/pull/349
12+
[#389]: https://github.com/actix/actix-net/pull/389
813

914

1015
## 2.0.0-beta.5 - 2021-04-20

actix-server/src/builder.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,6 @@ impl ServerBuilder {
335335
completion: None,
336336
})
337337
}
338-
_ => (),
339338
}
340339
}
341340
ServerCommand::Notify(tx) => {

actix-server/src/signals.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ use crate::server::Server;
88
#[allow(dead_code)]
99
#[derive(PartialEq, Clone, Copy, Debug)]
1010
pub(crate) enum Signal {
11-
/// SIGHUP
12-
Hup,
1311
/// SIGINT
1412
Int,
1513
/// SIGTERM
@@ -41,7 +39,6 @@ impl Signals {
4139

4240
let sig_map = [
4341
(unix::SignalKind::interrupt(), Signal::Int),
44-
(unix::SignalKind::hangup(), Signal::Hup),
4542
(unix::SignalKind::terminate(), Signal::Term),
4643
(unix::SignalKind::quit(), Signal::Quit),
4744
];

0 commit comments

Comments
 (0)