fix

Author: devksingh4

.gitignore

@@ -132,4 +132,7 @@ dist
 # AWS SAM
 .aws-sam/
 build/
-dist/
+dist/
+
+*.pyc
+__pycache__

src/config.ts

@@ -3,7 +3,7 @@ import { AppRoles, RunEnvironment } from "./roles.js";
 type GroupRoleMapping = Record<string, AppRoles[]>;
 type AzureRoleMapping = Record<string, AppRoles[]>;
 
-type ConfigType = {
+export type ConfigType = {
   GroupRoleMapping: GroupRoleMapping;
   AzureRoleMapping: AzureRoleMapping;
   ValidCorsOrigins: (string | RegExp)[];
@@ -14,6 +14,7 @@ type GenericConfigType = {
   DynamoTableName: string;
   ConfigSecretName: string;
   UpcomingEventThresholdSeconds: number;
+  AwsRegion: string;
 };
 
 type EnvironmentConfigType = {
@@ -24,6 +25,7 @@ const genericConfig: GenericConfigType = {
   DynamoTableName: "infra-events-api-records",
   ConfigSecretName: "infra-events-api-config",
   UpcomingEventThresholdSeconds: 1800, // 30 mins
+  AwsRegion: process.env.AWS_REGION || "us-east-1",
 } as const;
 
 const environmentConfig: EnvironmentConfigType = {

src/plugins/auth.ts

@@ -52,7 +52,7 @@ export type AadToken = {
   roles?: string[];
 };
 const smClient = new SecretsManagerClient({
-  region: process.env.AWS_REGION || "us-east-1",
+  region: genericConfig.AwsRegion,
 });
 
 const getSecretValue = async (
@@ -123,7 +123,7 @@ const authPlugin: FastifyPluginAsync = async (fastify, _options) => {
           }
           verifyOptions = { algorithms: ["HS256" as Algorithm] };
         } else {
-          const AadClientId = process.env.AadValidClientId;
+          const AadClientId = fastify.environmentConfig.AadValidClientId;
           if (!AadClientId) {
             request.log.error(
               "Server is misconfigured, could not find `AadValidClientId`!",

src/routes/events.ts

@@ -53,7 +53,7 @@ const getResponseJsonSchema = zodToJsonSchema(getResponseBodySchema);
 type EventsGetQueryParams = { upcomingOnly?: boolean };
 
 const dynamoClient = new DynamoDBClient({
-  region: process.env.AWS_REGION || "us-east-1",
+  region: genericConfig.AwsRegion,
 });
 
 const eventsPlugin: FastifyPluginAsync = async (fastify, _options) => {

src/types.d.ts

@@ -1,6 +1,7 @@
 import { FastifyRequest, FastifyInstance, FastifyReply } from "fastify";
 import { AppRoles, RunEnvironment } from "./roles.ts";
 import { AadToken } from "./plugins/auth.ts";
+import { ConfigType } from "./config.ts";
 declare module "fastify" {
   interface FastifyInstance {
     authenticate: (

tests/live_integration/__pycache__/conftest.cpython-312-pytest-8.1.1.pyc

@@ -0,0 +1,9 @@
+def test_get_events(api_client):
+    response = api_client.get("/api/v1/events")
+    assert response.status_code == 200
+    assert response.json() != []
+    
+def test_post_events_unauthenticated(api_client):
+    response = api_client.post("/api/v1/events")
+    assert response.status_code == 403
+    assert response.json()