Skip to content

Commit dee9fc6

Browse files
committed
Fix solemodels interface
1 parent b5abde7 commit dee9fc6

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

ext/DecisionTreeExt.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,14 @@ end
5454

5555
function SoleModels.solemodel(
5656
model::DT.Ensemble,
57+
args...;
5758
classlabels = nothing,
5859
featurenames = nothing,
59-
args...;
6060
keep_condensed = true,
6161
kwargs...
6262
)
6363
if isnothing(classlabels)
64-
error("Please, provide classlabels argument, as in solemodel(forest, classlabels; kwargs...). If your forest was trained via MLJ, use `classlabels = (mach).fitresult[2][sortperm((mach).fitresult[3])]`.")
64+
error("Please, provide classlabels argument, as in solemodel(forest; classlabels = classlabels, kwargs...). If your forest was trained via MLJ, use `classlabels = (mach).fitresult[2][sortperm((mach).fitresult[3])]`. Also consider providing `featurenames = report(mach).features`.")
6565
end
6666
if keep_condensed
6767
info = (;

test/DecisionTreeExt/forest.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ fit!(mach)
4141
classnames = (mach).fitresult[2]
4242
classnames = classnames[sortperm((mach).fitresult[3])]
4343
featurenames = report(mach).features
44-
solem = solemodel(fitted_params(mach).forest, classnames, featurenames)
44+
solem = solemodel(fitted_params(mach).forest; classnames, featurenames)
45+
solem = solemodel(fitted_params(mach).forest; classnames, featurenames, keep_condensed = false)
4546

4647
@test SoleData.scalarlogiset(X_test; allow_propositional = true) isa PropositionalLogiset
4748

0 commit comments

Comments
 (0)