Pending: Possibily not working in kde 6.3.0

[academo]

from @codeRSH #6 (comment)

Hi,

I am still having issues using it on KDE 6.3.0 on Fedora 41 Workstation over Wayland.

So basically ww -f firefox -c firefox opens firefox but doesn't switch to it, while ww -fa firefox -c firefox switches to firefox but doesn't open it in the first instance.

I report the same issue for dolphin as well.

Hence I am having to use two "different" commands to achieve the "run-raise" functionality and hence can't assign a shortcut to it.

[academo]

@codeRSH by chance I just got the update to 6.3.0 and I can confirm the script on its latest version is working as intended.

Are you running the latest version of the script? there were many changes in the last week.

if that still is not working for you, follow the debugging steps I linked you in the other issue and let me know.

[voidray]

I changed the script so it uses dbus-send instead of qdbus (In Endeavour OS I didn't have qdbus at all). It works with KDE Plasma 6.3.2. I used Claude 3.7 Sonnet for the change. Let me know if the change makes sense / works for you also.

function get_kwin_version() {
    kwinSupportInfo=$(dbus-send --session --dest=org.kde.KWin --type=method_call --print-reply=literal /KWin org.kde.KWin.supportInformation | grep "KWin version:" | tr -s " ") || exit 1
    kwinVersion=$(echo "$kwinSupportInfo" | awk '{print $3}') || exit 1
    echo "$kwinVersion"
}

if [[ -n "$INFO_ACTIVE" ]]; then
    kwinVersion=$(get_kwin_version)
    kwinMajorVersion="$(awk -F"." '{print $1}' <<< "$kwinVersion")" || exit 1    
    # This feature needs at least this KWin version
    readonly minimumVersion=6 || exit 1
    if [[ "$kwinMajorVersion" -lt "$minimumVersion" ]]; then
        echo "ERROR: This feature needs KWin $minimumVersion or later." >&2 
        exit 1
    fi

    # This way is similar to the one used on https://discuss.kde.org/t/xdotool-replacement-on-wayland/7242/9
    jsFile="$(mktemp)" || exit 1   # It is the file where the javascript code is going to be saved
    echo "print(\"$jsFile\",workspace.activeWindow.internalId);" > "$jsFile" || exit 1
    
    scriptId="$(dbus-send --session --dest=org.kde.KWin --print-reply=literal /Scripting org.kde.kwin.Scripting.loadScript string:"$jsFile" string:"info_script" | awk '{print $2}')" || exit 1
    timestamp="$(date +"%Y-%m-%d %H:%M:%S")" || exit 1
    # Starts the script
    dbus-send --session --dest=org.kde.KWin --print-reply=literal /Scripting/Script"$scriptId" org.kde.kwin.Script.run || exit 1
    
    # Uses some arguments that are also seen on https://github.com/jinliu/kdotool/blob/master/src/main.rs
    outputJournalctl="$(journalctl --since "$timestamp" --user --user-unit=plasma-kwin_wayland.service --user-unit=plasma-kwin_x11.service --output=cat -g "js: $jsFile")" || exit 1
    # Uses `awk` separately in order to avoid masking a return value, as Shellcheck recommends
    windowId="$(awk '{print $3}' <<< "$outputJournalctl")" || exit 1
    # Stops the script
    dbus-send --session --dest=org.kde.KWin --print-reply=literal /Scripting/Script"$scriptId" org.kde.kwin.Script.stop || exit 1
    
    # Shows the information about that window
    dbus-send --session --dest=org.kde.KWin --print-reply=literal /KWin org.kde.KWin.getWindowInfo uint32:"$windowId" || exit 1
    
    exit 0
fi

[academo]

Hi @voidray maybe you can open a PR with your changes? the important bit is that you must have support for qdbus too. otherwise you'll break it for people that don't have dbus-send.

[voidray]

I commited the changes in my fork https://github.com/voidray/ww-run-raise
I also created a PR draft (#18), but to be honest, the code changes were mainly done by Claude 3.7 Sonnet, so some of the changes may not be really necessary. I tested all my use cases sucessfully (see list in PR), but someone should take a look at each change before merging.

[voidray]

Hi @voidray maybe you can open a PR with your changes? the important bit is that you must have support for qdbus too. otherwise you'll break it for people that don't have dbus-send.

dbus-send is also used at the end of the current version of the script. Why then not just replace qdbus with dbus-send?

[voidray]

I did some testing on KDE Plasma 6.3.2 with the current version of the script:
Works: vlc, firefox, thunderbird

Doesn't work:
ww -fa Writer -c 'libreoffice --writer'
Writer is not started. Focussing works.

ww -fa Kdenlive -c 'flatpak run org.kde.kdenlive'
Kdenlive is not started. Focussing works.

ww -f okular -c okular
ww -f speedcrunch -c speedcrunch
Application is not started

ww -f gwenview -c gwenview
Application is started. Focussing doesn't work.