Skip to content

Commit 05c84c6

Browse files
committed
Refactor: Pkg Error Package
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
1 parent 5fdd531 commit 05c84c6

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

coap/api/transport.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ func handler(w mux.ResponseWriter, m *mux.Message) {
9898
switch m.Code() {
9999
case codes.GET:
100100
resp.SetCode(codes.Content)
101-
err = handleGet(m, w, msg, key)
101+
err = handleGet(m.Context(), m, w, msg, key)
102102
case codes.POST:
103103
resp.SetCode(codes.Created)
104104
err = service.Publish(m.Context(), key, msg)
@@ -122,7 +122,7 @@ func handler(w mux.ResponseWriter, m *mux.Message) {
122122
}
123123
}
124124

125-
func handleGet(m *mux.Message, w mux.ResponseWriter, msg *messaging.Message, key string) error {
125+
func handleGet(ctx context.Context, m *mux.Message, w mux.ResponseWriter, msg *messaging.Message, key string) error {
126126
var obs uint32
127127
obs, err := m.Options().Observe()
128128
if err != nil {

pkg/errors/errors.go

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,35 +86,36 @@ func Contains(e1, e2 error) bool {
8686
}
8787

8888
// Wrap returns an Error that wrap err with wrapper.
89-
func Wrap(wrapper, err error) error {
89+
func Wrap(wrapper, err error) Error {
9090
if wrapper == nil || err == nil {
91-
return wrapper
91+
return wrapper.(Error)
9292
}
9393
if w, ok := wrapper.(Error); ok {
9494
return &customError{
9595
msg: w.Msg(),
96-
err: cast(err),
96+
err: Cast(err),
9797
}
9898
}
9999
return &customError{
100100
msg: wrapper.Error(),
101-
err: cast(err),
101+
err: Cast(err),
102102
}
103103
}
104104

105105
// Unwrap returns the wrapper and the error by separating the Wrapper from the error.
106-
func Unwrap(err error) (error, error) {
106+
func Unwrap(err error) (Error, Error) {
107107
if ce, ok := err.(Error); ok {
108108
if ce.Err() == nil {
109109
return nil, New(ce.Msg())
110110
}
111111
return New(ce.Msg()), ce.Err()
112112
}
113113

114-
return nil, err
114+
return nil, Cast(err)
115115
}
116116

117-
func cast(err error) Error {
117+
// Cast returns an Error from an error.
118+
func Cast(err error) Error {
118119
if err == nil {
119120
return nil
120121
}

pkg/errors/sdk_errors.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func NewSDKError(err error) SDKError {
5656
statusCode: 0,
5757
customError: &customError{
5858
msg: e.Msg(),
59-
err: cast(e.Err()),
59+
err: Cast(e.Err()),
6060
},
6161
}
6262
}
@@ -80,7 +80,7 @@ func NewSDKErrorWithStatus(err error, statusCode int) SDKError {
8080
statusCode: statusCode,
8181
customError: &customError{
8282
msg: e.Msg(),
83-
err: cast(e.Err()),
83+
err: Cast(e.Err()),
8484
},
8585
}
8686
}

0 commit comments

Comments
 (0)