Skip to content

Commit acb770a

Browse files
authored
Add notes field on the DiscoveredPackage model #1342 (#1349)
Signed-off-by: tdruez <tdruez@nexb.com>
1 parent fdf1519 commit acb770a

File tree

8 files changed

+27
-1
lines changed

8 files changed

+27
-1
lines changed

CHANGELOG.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ v34.7.2 (unreleased)
3535
processed at once.
3636
https://github.com/nexB/scancode.io/issues/1287
3737

38+
- Add notes field on the DiscoveredPackage model.
39+
https://github.com/nexB/scancode.io/issues/1342
40+
3841
v34.7.1 (2024-07-15)
3942
--------------------
4043

scanpipe/api/serializers.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -391,6 +391,7 @@ class Meta:
391391
"tag",
392392
"primary_language",
393393
"description",
394+
"notes",
394395
"release_date",
395396
"parties",
396397
"keywords",
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# Generated by Django 5.0.7 on 2024-08-06 10:29
2+
3+
from django.db import migrations, models
4+
5+
6+
class Migration(migrations.Migration):
7+
8+
dependencies = [
9+
('scanpipe', '0066_alter_webhooksubscription_options_and_more'),
10+
]
11+
12+
operations = [
13+
migrations.AddField(
14+
model_name='discoveredpackage',
15+
name='notes',
16+
field=models.TextField(blank=True),
17+
),
18+
]

scanpipe/models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3256,6 +3256,7 @@ class DiscoveredPackage(
32563256
help_text=_("Unique identifier for this package."),
32573257
)
32583258
keywords = models.JSONField(default=list, blank=True)
3259+
notes = models.TextField(blank=True)
32593260
source_packages = models.JSONField(default=list, blank=True)
32603261
tag = models.CharField(blank=True, max_length=50)
32613262

scanpipe/tests/data/scancode/is-npm-1.0.0_summary.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@
164164
"tag": "",
165165
"primary_language": "JavaScript",
166166
"description": "Check if your code is running as an npm script",
167+
"notes": "",
167168
"release_date": null,
168169
"parties": [
169170
{

scanpipe/tests/test_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1048,7 +1048,7 @@ def test_scanpipe_api_serializer_get_model_serializer(self):
10481048
get_model_serializer(None)
10491049

10501050
def test_scanpipe_api_serializer_get_serializer_fields(self):
1051-
self.assertEqual(48, len(get_serializer_fields(DiscoveredPackage)))
1051+
self.assertEqual(49, len(get_serializer_fields(DiscoveredPackage)))
10521052
self.assertEqual(14, len(get_serializer_fields(DiscoveredDependency)))
10531053
self.assertEqual(37, len(get_serializer_fields(CodebaseResource)))
10541054
self.assertEqual(5, len(get_serializer_fields(CodebaseRelation)))

scanpipe/tests/test_models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2340,6 +2340,7 @@ def test_scanpipe_package_model_integrity_with_toolkit_package_model(self):
23402340
"resolved_from_dependencies",
23412341
"parent_packages",
23422342
"children_packages",
2343+
"notes",
23432344
]
23442345

23452346
package_data_only_field = ["datasource_id", "dependencies"]

scanpipe/views.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1891,6 +1891,7 @@ class DiscoveredPackageDetailsView(
18911891
"source_packages",
18921892
"keywords",
18931893
"description",
1894+
"notes",
18941895
"tag",
18951896
],
18961897
"icon_class": "fa-solid fa-circle-check",

0 commit comments

Comments
 (0)