Fix access to license/ app (#425)

* licenses/ will render all licenses without 500 error

https://github.com/nexB/scancode.io/blob/16644a60c6dbe81fa078fc6941fbd8be817fe935/scancodeio/urls.py#L53

include function is updated

Signed-off-by: lf32 <96695352+lf32@users.noreply.github.com>

* Tests for getting all licenses and single license

wrote test cases for licenses and moved all license urls to main urls.py

Signed-off-by: lf32 <96695352+lf32@users.noreply.github.com>

* Remove printing in tests

Signed-off-by: lf32 <96695352+lf32@users.noreply.github.com>

* Ran make valid successfully and renamed test functions

* Ran `make valid`
* Renamed test functions for licenses

Signed-off-by: lf32 <96695352+lf32@users.noreply.github.com>

* Removed Comment and corrected license path

* Removed Comment
* Chanded licenses/ back to license/

Signed-off-by: lf32 <96695352+lf32@users.noreply.github.com>

* correct variable in license tests

Signed-off-by: lf32 <96695352+lf32@users.noreply.github.com>

* status code updated

* added statuscode HttpResponseNotFound for unknown license
* corrected license tests
* override_settings for auth

Signed-off-by: lf32 <96695352+lf32@users.noreply.github.com>

Author: lf32

scancodeio/licenses.py

@@ -23,6 +23,7 @@
 from functools import lru_cache
 
 from django.http import HttpResponse
+from django.http import HttpResponseNotFound
 from django.urls import path
 from django.urls import reverse
 
@@ -67,7 +68,7 @@ def license_details_view(request, key):
         data = saneyaml.dump(licenses[key].to_dict())
         text = licenses[key].text
     except KeyError:
-        return HttpResponse(f"License {key} not found.")
+        return HttpResponseNotFound(f"License {key} not found.")
     return HttpResponse(f"<pre>{data}</pre><hr><pre>{text}</pre>")
 
 

scancodeio/urls.py

@@ -47,10 +47,11 @@
     path("accounts/profile/", AccountProfileView.as_view(), name="account_profile"),
 ]
 
+
 urlpatterns = auth_urlpatterns + [
     path("admin/", admin.site.urls),
     path("api/", include(api_router.urls)),
-    path("license/", include((licenses.urls, "license_app"))),
+    path("license/", include(licenses.urls)),
     path("", include("scanpipe.urls")),
     path("", RedirectView.as_view(url="project/")),
 ]

scanpipe/tests/test_auth.py

@@ -141,8 +141,8 @@ def test_scancodeio_auth_views_are_protected(self):
             ("run_detail", [a_uuid]),
             ("admin:index", None),
             ("rq_home", None),
-            ("license_app:license_list", None),
-            ("license_app:license_details", [a_path]),
+            ("license_list", None),
+            ("license_details", [a_path]),
         ]
 
         for viewname, args in views:

scanpipe/tests/test_licenses.py

@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: Apache-2.0
+#
+# http://nexb.com and https://github.com/nexB/scancode.io
+# The ScanCode.io software is licensed under the Apache License version 2.0.
+# Data generated with ScanCode.io is provided as-is without warranties.
+# ScanCode is a trademark of nexB Inc.
+#
+# You may not use this software except in compliance with the License.
+# You may obtain a copy of the License at: http://apache.org/licenses/LICENSE-2.0
+# Unless required by applicable law or agreed to in writing, software distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations under the License.
+#
+# Data Generated with ScanCode.io is provided on an "AS IS" BASIS, WITHOUT WARRANTIES
+# OR CONDITIONS OF ANY KIND, either express or implied. No content created from
+# ScanCode.io should be considered or used as legal advice. Consult an Attorney
+# for any legal advice.
+#
+# ScanCode.io is a free software code scanning tool from nexB Inc. and others.
+# Visit https://github.com/nexB/scancode.io for support and download.
+
+from unittest import mock
+
+from django.test import TestCase
+from django.test import override_settings
+from django.urls import reverse
+
+
+@override_settings(SCANCODEIO_REQUIRE_AUTHENTICATION=False)
+class LicensesTest(TestCase):
+    def test_license_list_view(self):
+        url = reverse("license_list")
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 200)
+
+    def test_license_details_view(self):
+        keys = ["apache-2.0", "abcdefg"]
+        license_url = reverse("license_details", args=(keys[0],))
+        dummy_license_url = reverse("license_details", args=(keys[1],))
+        response = [self.client.get(license_url), self.client.get(dummy_license_url)]
+        self.assertEqual(response[0].status_code, 200)
+        self.assertEqual(response[1].status_code, 404)