Skip to content

Commit 5f21555

Browse files
committed
Add unit test for the "Package Compliance Alert" chart #1699
Signed-off-by: tdruez <tdruez@nexb.com>
1 parent d76117b commit 5f21555

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

CHANGELOG.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ v34.12.0 (unreleased)
3434
https://github.com/aboutcode-org/scancode.io/issues/1697
3535

3636
- Add "Package Compliance Alert" chart in the Policies section.
37+
https://github.com/aboutcode-org/scancode.io/pull/1699
3738

3839
v34.11.0 (2025-05-02)
3940
---------------------

scanpipe/tests/test_views.py

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -500,19 +500,28 @@ def test_scanpipe_views_project_details_charts_view(self):
500500
def test_scanpipe_views_project_details_charts_compliance_alert(self):
501501
url = reverse("project_charts", args=[self.project1.slug])
502502
resource = make_resource_file(self.project1)
503-
expected = 'id="compliance_alert_chart"'
503+
expected_resource_id = 'id="compliance_alert_chart"'
504+
expected_package_id = 'id="package_compliance_alert_chart"'
504505

505506
response = self.client.get(url)
506-
self.assertNotContains(response, expected)
507+
self.assertNotContains(response, expected_resource_id)
508+
self.assertNotContains(response, expected_package_id)
507509

508510
# Do not trigger the save() logic.
509511
CodebaseResource.objects.filter(id=resource.id).update(
510512
compliance_alert=CodebaseResource.Compliance.ERROR
511513
)
514+
make_package(
515+
self.project1,
516+
package_url="pkg:generic/name@1.0",
517+
compliance_alert=DiscoveredPackage.Compliance.WARNING,
518+
)
512519

513520
response = self.client.get(url)
514-
self.assertContains(response, expected)
521+
self.assertContains(response, expected_resource_id)
522+
self.assertContains(response, expected_package_id)
515523
self.assertContains(response, '{"error": 1}')
524+
self.assertContains(response, '{"warning": 1}')
516525

517526
def test_scanpipe_views_project_details_charts_copyrights(self):
518527
url = reverse("project_charts", args=[self.project1.slug])
@@ -617,7 +626,7 @@ def test_scanpipe_views_project_details_compliance_panel_availability(
617626
make_package(
618627
self.project1,
619628
package_url="pkg:generic/name@1.0",
620-
compliance_alert=CodebaseResource.Compliance.ERROR,
629+
compliance_alert=DiscoveredPackage.Compliance.ERROR,
621630
)
622631

623632
expected_url = reverse("project_compliance_panel", args=[self.project1.slug])
@@ -985,7 +994,7 @@ def test_scanpipe_views_project_compliance_panel_view(self, mock_policies_enable
985994
make_package(
986995
self.project1,
987996
package_url="pkg:generic/name@1.0",
988-
compliance_alert=CodebaseResource.Compliance.ERROR,
997+
compliance_alert=DiscoveredPackage.Compliance.ERROR,
989998
)
990999

9911000
mock_policies_enabled.return_value = False

0 commit comments

Comments
 (0)