Skip to content

Commit 4da3913

Browse files
authored
Fix issue with conflicting groups checkbox id in Add pipeline modal #1353 (#1354)
Signed-off-by: tdruez <tdruez@nexb.com>
1 parent 37fd1c2 commit 4da3913

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

CHANGELOG.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ v34.7.2 (unreleased)
3838
- Add notes field on the DiscoveredPackage model.
3939
https://github.com/nexB/scancode.io/issues/1342
4040

41+
- Fix an issue with conflicting groups checkbox id in the Add pipeline modal.
42+
https://github.com/nexB/scancode.io/issues/1353
43+
4144
v34.7.1 (2024-07-15)
4245
--------------------
4346

Makefile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,10 @@ test:
125125
@echo "-> Run the test suite"
126126
${MANAGE} test --noinput
127127

128+
fasttest:
129+
@echo "-> Run the test suite without the PipelinesIntegrationTest"
130+
${MANAGE} test --noinput --exclude-tag slow
131+
128132
worker:
129133
${MANAGE} rqworker --worker-class scancodeio.worker.ScanCodeIOWorker --queue-class scancodeio.worker.ScanCodeIOQueue --verbosity 2
130134

@@ -152,4 +156,4 @@ offline-package: docker-images
152156
@mkdir -p dist/
153157
@tar -cf dist/scancodeio-offline-package-`git describe --tags`.tar build/
154158

155-
.PHONY: virtualenv conf dev envfile install doc8 check valid check-deploy clean migrate upgrade postgresdb sqlitedb backupdb run test docs bump docker-images offline-package
159+
.PHONY: virtualenv conf dev envfile install doc8 check valid check-deploy clean migrate upgrade postgresdb sqlitedb backupdb run test fasttest docs bump docker-images offline-package

scanpipe/templates/scanpipe/modals/add_pipeline_modal.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@
3333
{% if pipeline_info.available_groups %}
3434
<div class="ml-2 mt-1">
3535
{% for group in pipeline_info.available_groups %}
36-
<label class="checkbox ml-1" for="id_{{ group }}">
36+
<label class="checkbox ml-1" for="id_{{ pipeline_name }}_{{ group }}">
3737
<span class="tag is-warning has-text-weight-bold">
38-
<input type="checkbox" name="selected_groups" value="{{ group }}" id="id_{{ group }}" class="mr-1">
38+
<input type="checkbox" name="selected_groups" value="{{ group }}" id="id_{{ pipeline_name }}_{{ group }}" class="mr-1">
3939
{{ group }}
4040
</span>
4141
</label>

0 commit comments

Comments
 (0)